Skip to content

Commit 3bebfb9

Browse files
committed
chore(ci): remove functional tests, evaluate later
1 parent 1386710 commit 3bebfb9

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ env:
1515
- CC=gcc-4.9
1616
matrix:
1717
- GROUP=coverage
18-
- GROUP=functional
1918
- GROUP=lint
2019
- GROUP=flow
2120

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ install:
1515
test_script:
1616
- node --version
1717
- npm --version
18-
- npm run test:functional
18+
- npm run test:unit

test/main/launch.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ describe('launch', () => {
99
// Note that we can't use => functions because we need `this` to be mocha's
1010
this.timeout(10000);
1111

12+
let win;
1213
ipc.on('nteract:ping:kernel', (event, kernel) => {
1314
win.close();
14-
expect(kernel).to.equal('python3');
15+
expect(kernel === 'inodejs' || kernel === 'python3').to.be.true;
1516
done();
1617
});
1718

18-
const win = launch('example-notebooks/intro.ipynb');
19+
win = launch('example-notebooks/intro.ipynb');
1920
win.hide(); // To make it nicer to run locally
2021

2122
setTimeout(() => {

test/main/launchNewNotebook.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ describe('launchNewNotebook', () => {
99
// Note that we can't use => functions because we need `this` to be mocha's
1010
this.timeout(10000);
1111

12+
let win;
1213
ipc.on('nteract:ping:kernel', (event, kernel) => {
1314
win.close();
14-
expect(kernel).to.equal('python3');
15+
expect(kernel).to.equal('inodejs');
1516
done();
1617
});
1718

18-
const win = launchNewNotebook('python3');
19+
win = launchNewNotebook('inodejs');
1920
win.hide(); // To make it nicer to run locally
2021

2122
setTimeout(() => {

0 commit comments

Comments
 (0)