-
Notifications
You must be signed in to change notification settings - Fork 71
Open
Labels
Milestone
Description
Description
We're currently using VCR to stub GitHub API calls in the specs for multiple classes. Right now, this adds over 2K lines to the codebase.
We'd like to keep the VCR cassettes for all Github service object specs, and replace any VCRs associated with Event, User, Project, FeaturedProject, and/or EventRegistration with a simpler stubbing method. Now that we know it works, it would also be nice to shorten the date-span being passed to the API (thus meaning a smaller number of results).
Ask
Use RSpec stubbing to avoid using calls to the Github service object in any unit tests that are not the actual Github service object.
To Do (This work should be more than one pull request.)
- Stub out
Githubservice object calls- in the
Userspecs - in the
Projectspecs - in the
FeaturedProjectspecs - in the
EventRegistrationspecs
- in the
- Delete unnecessary VCR .yml files post-stubbing.
- Use shorter time periods for the existing
Githubservice object calls
Reactions are currently unavailable