Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification bug #163

Closed
rodrigo-puente opened this issue Apr 22, 2014 · 3 comments
Closed

Minification bug #163

rodrigo-puente opened this issue Apr 22, 2014 · 3 comments

Comments

@rodrigo-puente
Copy link

Hey there.

I have some stylesheets that just dont work if they are minified, my guess is that some file messed up the whole minification. Is there an option to only specify concatenation and leave the file not minified?

@evantishuk
Copy link

I had a minification bug that (after much headache) I tracked down to Opera vendor prefixes. They break any rules that follow them in the document. You may want to check your css for the -o- prefix and remove them.

@rodrigo-puente
Copy link
Author

Is there any other way rather than tracking that vendor prefix? I've noticed that production environment minifies the file while a local environment doesn't, maybe there's a way to set the same rule to production environment that hasn't been documented?

@evantishuk
Copy link

AFAIK, you can force production not to minify in the package's configuration file. That doesn't seem like a great solution though if you can simply patch the CSS.

The Opera problem lies within the minification library itself (https://github.com/nitra/PhpMin). Specifically in this area: https://github.com/nitra/PhpMin/blob/master/CssMin/CssMin.php#L2989. Notice, there are no -o- Opera translations in those arrays? I've posted an issue with the maintainer (nitra/PhpMin#5) and there's already a bug/proposal issue here (#155) to investigate a different minifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants