Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Term Entry] Python Dates: .strptime() #5755 #5900

Merged
merged 13 commits into from
Jan 12, 2025
Merged

[Term Entry] Python Dates: .strptime() #5755 #5900

merged 13 commits into from
Jan 12, 2025

Conversation

EduardoGallego94
Copy link
Contributor

Description

This is a new entry on .strptime() method in Python.
New file "strptime.md" in content/python/concepts/dates/terms/strptime/

Issue Solved

Closes #5755 issue-number

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Dec 28, 2024
@mamtawardhani mamtawardhani added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Dec 28, 2024
mamtawardhani
mamtawardhani requested changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EduardoGallego94, thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you! 😃

content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Outdated Show resolved Hide resolved
content/python/concepts/dates/terms/strptime/strptime.md Show resolved Hide resolved
EduardoGallego94 and others added 8 commits December 30, 2024 19:14
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
1a6089d 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
82ad5d8 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
2454a0a 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
1bce30a 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
93aa5c2 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94 @mamtawardhani
Update content/python/concepts/dates/terms/strptime/strptime.md
0f741c5 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@EduardoGallego94
Merge branch 'Codecademy:main' into strptime
7e0e141
@EduardoGallego94
strptime updated
60df20b
@EduardoGallego94
Copy link
Contributor Author

reviewed, thanks!

@mamtawardhani
Update strptime.md
78ed574 
minor fixes
mamtawardhani
mamtawardhani approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @EduardoGallego94 😄

The entry looks good for a second round of review!🚀

@Sriparno08 Sriparno08 self-assigned this Jan 9, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 9, 2025
Sriparno08
Sriparno08 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @EduardoGallego94!

@Sriparno08 Sriparno08 merged commit 75fe50f into Codecademy:main Jan 12, 2025
7 checks passed
@github-actions GitHub Actions
Copy link

👋 @EduardoGallego94
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/python/dates/strptime

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 12, 2025
@EduardoGallego94 EduardoGallego94 deleted the strptime branch January 13, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@mamtawardhani mamtawardhani mamtawardhani approved these changes

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels
new entry New entry or entries python Python entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Dates: .strptime()
4 participants
@EduardoGallego94 @CLAassistant @mamtawardhani @Sriparno08