-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenerateBlocks Container Background Image Not Optimized When Selector is Set to Pseudo Element #842
Comments
@kushh23 I checked both modes on the backend, and it looks like both display the local image URL. However, on the frontend, it seems to show the optimized image URL. Backend screencast: Frontend screencast(Pseudo Element): Please let me know if I'm making any mistakes. |
The backend editor always shows the Optimole URL, as the Optimole image replacement only works on the front end. (When images are hosted on site i.e offload is disabled) I tested it again, and as you can see on this page - https://begdowntown.s4-tastewp.com/5-2/ the image is still not optimized. In the backend, it is set on the pseudo-element option Here is the instance details:
|
@kushh23 It appears to be working with the pseudo-element option in my test instance.
Please check and let me know if I'm doing anything incorrectly. Thanks |
Hi @girishpanchal30, I checked your test instance before it got expired, on your instance, the issue do not occur, but on my end, I am still able to replicate it. I checked again on a fresh test instance from InstaWP as well, and it is still replicable with the default twenty-twenty themes.
|
@kushh23 I've been debugging your test instance, and it appears that the We have two options to change the CSS type:
add_filter( 'generateblocks_css_print_method', function() {
return 'inline';
}, 999 ); Thanks! |
@girishpanchal30 Thank you for debugging this issue. I can confirm that if I follow the above steps, the issue will be solved. So, is this issue related to the GenerateBlocks plugin or we can do something from our end to solve this. |
Description
A user reported that their GenerateBlocks's homepage container background image was not being optimized by Optimole. Upon investigation, I discovered that under the background image option, there is a setting of Selector; when it is set to "Pseudo Element," it prevents Optimole from optimizing the image. However, switching the option to "Element" allows Optimole to optimize it as expected.
Could we investigate whether this issue originates from our side or theirs? If it's on our end, we should address it to ensure compatibility. In the meantime, I have advised the user to set the option to "Element."
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet or Help Scout ticket
Reported here - https://secure.helpscout.net/conversation/2725973401/436218?viewId=2353196
Environment info
No response
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: