-
Notifications
You must be signed in to change notification settings - Fork 7
Remove es-check dependency #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@graymalkin77 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Co-authored-by: kwinto <90881+kwinto@users.noreply.github.com>
Co-authored-by: kwinto <90881+kwinto@users.noreply.github.com>
|
@copilot run npm install and commit updates |
Co-authored-by: kwinto <90881+kwinto@users.noreply.github.com>
Fixed in commit 304aeef. The package-lock.json was regenerated without the --legacy-peer-deps flag to ensure proper sync with CI pipeline that uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the es-check package from the project's development dependencies. The change simplifies the dependency tree by eliminating an unused ECMAScript compatibility checking tool.
- Removed
es-checkfrom devDependencies in package.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Success criteria
es-checkpackage is removed from devDependencieses-checkare removed from package-lock.jsonHow to test
es-checkis absent frompackage.jsondevDependenciesnpm installand confirm no es-check packages are installednpm cito verify package-lock.json is properly synchronizednpm run buildto verify build process worksnpm run lintto verify linting worksSecurity
Additional considerations
Documentation Considerations
No documentation changes required. The es-check tool was not referenced in any user-facing documentation or developer guides.
Additional Notes
The package-lock.json was regenerated without the
--legacy-peer-depsflag to ensure proper synchronization with the CI pipeline that usesnpm ci. This resolves peer dependencies correctly and ensures the lock file is compatible with Node 22 used in CI workflows.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.