Skip to content

Conversation

@kwinto
Copy link
Contributor

@kwinto kwinto commented Dec 1, 2025

This PR adds CodeQL scan, fixes a finding in our source code + patches some minor issues in build.

The patches are created by LLM. If we find any problems with this new approach, we should disable the post-build patches all together. They do not fix anything critical or high importance.

Please test

  • sanitization functionality working as expeted.
  • list background image functionality

Copilot AI review requested due to automatic review settings December 1, 2025 15:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces local CodeQL scanning infrastructure and patches security findings identified by the scan. The changes include a complete scanning workflow with scripts, configuration, and remediation of incomplete sanitization issues.

Key changes:

  • Added CodeQL scanning infrastructure with configuration file and shell script for local analysis
  • Fixed incomplete HTML sanitization by globally replacing angle brackets instead of single-occurrence replacement
  • Implemented post-build security patching script to address CodeQL findings in compiled bundles

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/sanitize.ts Fixed incomplete sanitization by using global regex replacement for angle brackets
scripts/postbuild-secure-patch.mjs Added post-build script to patch security issues in compiled dist files
scripts/codeql-scan.sh Added comprehensive shell script for running local CodeQL analysis
package.json Integrated security patch into build pipeline and added CodeQL scan commands
codeql-config.yml Added CodeQL configuration with paths and exclusions for scanning

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 2, 2025 05:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kwinto kwinto requested a review from sushmi21 December 2, 2025 05:55
Copilot AI review requested due to automatic review settings December 2, 2025 06:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 2, 2025 13:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 2, 2025 15:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Dec 2, 2025

@kwinto I've opened a new pull request, #209, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 3 commits December 2, 2025 15:14
Co-authored-by: kwinto <90881+kwinto@users.noreply.github.com>
Co-authored-by: kwinto <90881+kwinto@users.noreply.github.com>
Replace rm -rf with cross-platform rimraf package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants