Rename method name and update coumment

Author: laguirre-cs

src/commands/pipelines.js

@@ -278,8 +278,7 @@ export const PipelineGenerateCommand = class extends TemplateGenerationCommand {
     super(program, 'Pipeline', 'pipelines', 'pipelinename', 'pipelineTemplateConfig');
   }
 
-  // TODO: Need a better way to handle this filtering
-  filterByFileName(filepath) {
+  shouldTemplateFile(filepath) {
     // NOTE: It is common for dbt's templating (jinja2?) to collide with Lodash's templating syntax.
     // Current workaround is to exclude DBT & SQL files from templating, only downside is that those
     // can't use the {{pipelinename}} variable.

src/commands/workspaces/generate.js

@@ -69,8 +69,8 @@ export class TemplateGenerationCommand {
         if (typeof this.configureSubcommand !== 'function') {
             throw new TypeError('Cannot construct instance of TemplateGenerationCommand without overriding async method "configureSubcommand()"!');
         }
-        if (typeof this.filterByFileName !== 'function') {
-            throw new TypeError('Cannot construct instance of TemplateGenerationCommand without overriding async method "filterByFileName(string) -> bool"!');
+        if (typeof this.shouldTemplateFile !== 'function') {
+            throw new TypeError('Cannot construct instance of TemplateGenerationCommand without overriding async method "shouldTemplateFile(string) -> bool"!');
         }
         // Set options controlling direct behavior
         this.program = program;
@@ -89,6 +89,9 @@ export class TemplateGenerationCommand {
      * @param {option} options CLI runtime options
      */
     async init(name, destination, options) {
+        // NOTE: The code originally assigned below properties across multiple methods, which
+        //  made keeping track of properties difficult. These assignments have been grouped
+        //  together in a single method for simplicity.
         this.options = options;
         this.name = name;
         this.destination = destination;
@@ -330,17 +333,17 @@ export class TemplateGenerationCommand {
     }
 
     /**
-     * Returns whether a given file (path) in the template should be excluded from the template.
-     * Should return `true` if the file should be copied without modification.
+     * Returns whether a given file (path) should have templating applied to it.
+     * Should return `false` if the file should be copied without modification.
      *
-     * The default implementation allows for all files to be templated.
+     * The default implementation always returns `true` - allowing all files to be templated.
      *
      * @param {string} filepath
-     * @returns {boolean} true if the file should NOT be templated, false otherwise
+     * @returns {boolean} true if the file should be templated, false otherwise.
      */
     // eslint-disable-next-line no-unused-vars
-    filterByFileName(filepath) {
-        return false;
+    shouldTemplateFile(filepath) {
+        return true;
     }
 
     /**
@@ -365,8 +368,8 @@ export class TemplateGenerationCommand {
                         template: template.template,
                     };
                     let buf = await this.readFile(f.path);
-                    /// Try not to template any non-text files, and allow for a filter
-                    if (isText(null, buf) && !this.filterByFileName(f.path)) {
+                    /// Try not to template any non-text files and allow filering based on file names
+                    if (isText(null, buf) && this.shouldTemplateFile(f.path)) {
                         buf = Buffer.from(_.template(buf.toString(), { interpolate: /{{([\s\S]+?)}}/g })(templateVars));
                     }
                     const relPath = f.path.slice(path.dirname(template.template.path).length);