Fixed checks on message length #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by Android Studio
updated .gitignore (Cogno-Marco#8)
…gStrategy set by the user of this library. Two tests still need to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premise
Fixes #19 .
Changes
1. Checks on the length of
SMSMessageobjects now take into account the customMessageParsingStrategyused.To avoid valid messages becoming invalid after the strategy is changed, I removed the possibility to change the strategy. Now it must be set before using any other methods from this library.
2. Improved specifications of some methods
3. Renamed some methods and interfaces according to what they do
A method that parses an
SMSMessageobject should be calledparseMessage(), notparseData(). A strategy used for parsing messages should be calledMessageParsingStrategy, notMessageParseStrategy.Side changes
Changed the
HIDDEN_CHARACTERofDefaultSMSMessageParsingStrategyto a character that is transmitted correctly, even though this was already done in #46 .