From 9fbabecb065e071e8d9033ac2664570bd1b19197 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jer=C3=B4me=20Bakker?= <jeabakker@coldtrick.com>
Date: Tue, 18 Jul 2023 17:12:05 +0200
Subject: [PATCH] fixed: buttons have a discernible text

---
 views/default/form/compose/canvas.php               |  2 +-
 views/default/form/compose/canvas/page.php          |  2 +-
 views/default/form/compose/edit_field.php           |  2 +-
 views/default/forms/forms/compose.php               |  2 +-
 views/default/forms/forms/definition/import.php     |  2 +-
 views/default/forms/forms/edit.php                  |  2 +-
 views/default/forms/forms/submit.php                | 10 ++++------
 views/default/forms/forms/validation_rules/edit.php |  2 +-
 8 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/views/default/form/compose/canvas.php b/views/default/form/compose/canvas.php
index 8074a26..9201d5a 100644
--- a/views/default/form/compose/canvas.php
+++ b/views/default/form/compose/canvas.php
@@ -32,7 +32,7 @@
 	'#type' => 'button',
 	'icon' => 'plus',
 	'class' => 'elgg-button-action forms-compose-add-page',
-	'value' => elgg_echo('forms:compose:page:add'),
+	'text' => elgg_echo('forms:compose:page:add'),
 ]));
 
 echo elgg_format_element('ul', ['class' => 'forms-compose-list'], $pages_result);
diff --git a/views/default/form/compose/canvas/page.php b/views/default/form/compose/canvas/page.php
index 3637c8b..e2e30f9 100644
--- a/views/default/form/compose/canvas/page.php
+++ b/views/default/form/compose/canvas/page.php
@@ -11,7 +11,7 @@
 	'#type' => 'button',
 	'icon' => 'plus',
 	'class' => 'elgg-button-action forms-compose-add-section',
-	'value' => elgg_echo('forms:compose:section:add'),
+	'text' => elgg_echo('forms:compose:section:add'),
 ]));
 
 $page_title = elgg_view_icon('minus-square-regular', [
diff --git a/views/default/form/compose/edit_field.php b/views/default/form/compose/edit_field.php
index fe3941f..0535165 100644
--- a/views/default/form/compose/edit_field.php
+++ b/views/default/form/compose/edit_field.php
@@ -118,7 +118,7 @@
 	[
 		'#type' => 'button',
 		'class' => 'elgg-button-action forms-compose-field-save',
-		'value' => elgg_echo('save'),
+		'text' => elgg_echo('save'),
 	],
 ];
 
diff --git a/views/default/forms/forms/compose.php b/views/default/forms/forms/compose.php
index b97d0b8..279b082 100644
--- a/views/default/forms/forms/compose.php
+++ b/views/default/forms/forms/compose.php
@@ -36,7 +36,7 @@
 	'#type' => 'button', // don't use submit to prevent submit on enter keydown
 	'icon' => 'save',
 	'class' => 'elgg-button-submit forms-compose-save',
-	'value' => elgg_echo('save'),
+	'text' => elgg_echo('save'),
 ]);
 
 elgg_set_form_footer($footer);
diff --git a/views/default/forms/forms/definition/import.php b/views/default/forms/forms/definition/import.php
index 6cdf61f..6ea5c9a 100644
--- a/views/default/forms/forms/definition/import.php
+++ b/views/default/forms/forms/definition/import.php
@@ -34,7 +34,7 @@
 
 $footer = elgg_view_field([
 	'#type' => 'submit',
-	'value' => elgg_echo('import'),
+	'text' => elgg_echo('import'),
 ]);
 $footer .= elgg_view_field([
 	'#type' => 'hidden',
diff --git a/views/default/forms/forms/edit.php b/views/default/forms/forms/edit.php
index d35dc0d..8164ced 100644
--- a/views/default/forms/forms/edit.php
+++ b/views/default/forms/forms/edit.php
@@ -92,7 +92,7 @@
 
 $footer .= elgg_view_field([
 	'#type' => 'submit',
-	'value' => elgg_echo('save'),
+	'text' => elgg_echo('save'),
 ]);
 
 elgg_set_form_footer($footer);
diff --git a/views/default/forms/forms/submit.php b/views/default/forms/forms/submit.php
index 88684ec..e706678 100644
--- a/views/default/forms/forms/submit.php
+++ b/views/default/forms/forms/submit.php
@@ -102,7 +102,7 @@
 	
 	$footer .= elgg_view_field([
 		'#type' => 'submit',
-		'value' => elgg_echo('submit'),
+		'text' => elgg_echo('submit'),
 	]);
 } else {
 	foreach ($tabs as $index => $tab) {
@@ -116,7 +116,7 @@
 					'elgg-button-action',
 					'forms-submit-buttons-prev',
 				],
-				'value' => elgg_echo('previous'),
+				'text' => elgg_echo('previous'),
 			];
 		}
 		
@@ -128,7 +128,7 @@
 					'elgg-button-submit',
 					'forms-submit-buttons-next',
 				],
-				'value' => elgg_echo('next'),
+				'text' => elgg_echo('next'),
 			];
 		}
 		
@@ -136,12 +136,10 @@
 		if (($index + 1) === count($tabs)) {
 			$buttons[] = [
 				'#type' => 'submit',
-				'value' => elgg_echo('submit'),
+				'text' => elgg_echo('submit'),
 			];
 		}
 		
-		
-		
 		$tabs[$index]['content'] .= elgg_view('input/fieldset', [
 			'class' => 'forms-submit-buttons',
 			'fields' => $buttons,
diff --git a/views/default/forms/forms/validation_rules/edit.php b/views/default/forms/forms/validation_rules/edit.php
index c2dfc7d..ae3e1a8 100644
--- a/views/default/forms/forms/validation_rules/edit.php
+++ b/views/default/forms/forms/validation_rules/edit.php
@@ -46,7 +46,7 @@
 // footer
 $footer = elgg_view_field([
 	'#type' => 'submit',
-	'value' => elgg_echo('save'),
+	'text' => elgg_echo('save'),
 ]);
 if (!empty($name)) {
 	$footer .= elgg_view_field([