Async Implementation Clarification

[rmartin16]

Hello; I am evaluating this httpx add-on for incorporation in to a FastAPI app for client id/secret oauth2.

Everything is working well; however, I am trying to understand this request to get the token:

httpx_auth/httpx_auth/_oauth2/common.py

Lines 71 to 76 in e001f07

	def request_new_grant_with_post(
	url: str, data, grant_name: str, client: httpx.Client
	) -> (str, int, str):
	response = client.post(url, data=data)
	if response.is_error:

Is the implication here that a sync http request is made for the token?

If so, this is going to block the asyncio event loop (and the entire app) until the token is returned.

[Colin-b]

Hello, yes it is. There is currently an effort into trying to add async support. However I must admit I didn't have a lot of time to review current proposal on the implementation.

Note however that the default token cache is in memory and any kind of cache can be implemented. So for instance, if your app runs multiple workers you could use some kind of shared cache to effectively block only once per token duration (usually multiple hours). Making this synchronous call negligeable.