Skip to content

Conversation

@jbostoen
Copy link

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? No
Type of change? Enhancement

Symptom (bug) / Objective (enhancement)

Enhancement: Ability to detect iTop API versions 1.3 and 1.4 ( https://www.itophub.io/wiki/page?id=latest:advancedtopics:rest_json#changes_history )

It also changes the logic to try most recent versions of the API first.

Proposed solution (bug and enhancement)

Just add the missing values.

Checklist before requesting a review

  • I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

Checklist of things to do before PR is ready to merge

@jf-cbd jf-cbd changed the title Add detection of iTop API versions 1.3 and 1.4. N°8890 - Add detection of iTop API versions 1.3 and 1.4. Nov 6, 2025
- Improve error message: Include hints on what to validate.
@jbostoen
Copy link
Author

The exception now also contains hints on what can go wrong (invalid URL, invalid credentials, missing profile, ... ).

Before the patch; it would just try all versions; then assume iTop API version 1.0 and fail later on.

@jf-cbd
Copy link
Member

jf-cbd commented Nov 28, 2025

Thanks for your PR, it got functionally accepted. We'll perform technical review in the upcoming days/weeks.

@jf-cbd jf-cbd moved this from First review needed to Pending technical review in Combodo PRs dashboard Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending technical review

Development

Successfully merging this pull request may close these issues.

3 participants