From 0d2a88f001eb9e8c189016851fe7dfa0570b3b0e Mon Sep 17 00:00:00 2001 From: huchenlei Date: Thu, 9 Jan 2025 14:26:03 -0500 Subject: [PATCH] [BrowserTest] Disable flaky test --- browser_tests/nodeSearchBox.spec.ts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/browser_tests/nodeSearchBox.spec.ts b/browser_tests/nodeSearchBox.spec.ts index f7523c38a..b761d4a8f 100644 --- a/browser_tests/nodeSearchBox.spec.ts +++ b/browser_tests/nodeSearchBox.spec.ts @@ -132,7 +132,33 @@ test.describe('Node search box', () => { await expectFilterChips(comfyPage, ['MODEL']) }) - test('Outer click dismisses filter panel but keeps search box visible', async ({ + // Flaky test. + // Sample test failure: + // https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/12696912248/job/35391990861?pr=2210 + /* + 1) [chromium-2x] › nodeSearchBox.spec.ts:135:5 › Node search box › Filtering › Outer click dismisses filter panel but keeps search box visible + + Error: expect(locator).not.toBeVisible() + + Locator: getByRole('dialog').locator('div').filter({ hasText: 'Add node filter condition' }) + Expected: not visible + Received: visible + Call log: + - expect.not.toBeVisible with timeout 5000ms + - waiting for getByRole('dialog').locator('div').filter({ hasText: 'Add node filter condition' }) + + + 143 | + 144 | // Verify the filter selection panel is hidden + > 145 | expect(panel.header).not.toBeVisible() + | ^ + 146 | + 147 | // Verify the node search dialog is still visible + 148 | expect(comfyPage.searchBox.input).toBeVisible() + + at /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/browser_tests/nodeSearchBox.spec.ts:145:32 + */ + test.skip('Outer click dismisses filter panel but keeps search box visible', async ({ comfyPage }) => { await comfyPage.searchBox.filterButton.click()