Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in creating different keys with the same value #13

Open
cagdasfil opened this issue Jan 2, 2025 · 0 comments · May be fixed by #14
Open

Error in creating different keys with the same value #13

cagdasfil opened this issue Jan 2, 2025 · 0 comments · May be fixed by #14
Assignees

Comments

@cagdasfil
Copy link
Collaborator

When there are two different keys with the same value in secrets.json, plugin creates only one obfuscated secret in cpp file instead of creating two.

Although the keys are defined differently in secrets.json, plugin logs a message as "Key already added in C++ !".

The source of the problem is that plugin checks if there is an obfuscated value which is already added to cpp file. Instead of checking the obfuscated value, plugin should check the key to detect if it is already added.

Example secrets.json file to reproduce the error:

[
  {
    "key": "prodOnlyKey1",
    "value": "prodOnlyValue1",
    "sourceSet": "prod"
  },
  {
    "key": "prodOnlyKey2",
    "value": "prodOnlyValue1",
    "sourceSet": "prod"
  }
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant