Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Google Pay on-site #63

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Introduce Google Pay on-site #63

wants to merge 22 commits into from
+2,192 −571

Conversation

coldic3
Copy link
Member

@coldic3 coldic3 commented Oct 7, 2024 •
edited
Loading

image

@coldic3 coldic3 changed the title Introduce Google Pay type for Tpay payment method Introduce Google Pay on-site Oct 7, 2024
@coldic3 coldic3 force-pushed the feature/support-google-pay-on-site branch from fd88c2c to da775c1 Compare October 7, 2024 15:07
@coldic3 coldic3 linked an issue Oct 7, 2024 that may be closed by this pull request
Add support for Google Pay #46
Open
5 tasks
@coldic3 coldic3 force-pushed the feature/support-google-pay-on-site branch 3 times, most recently from a00e7b3 to 369a8b1 Compare October 10, 2024 13:26
coldic3
coldic3 commented Oct 10, 2024
View reviewed changes
templates/shop/cart/complete/_google_pay.html.twig
const ENVIRONMENT = '{{ productionMode ? 'PRODUCTION' : 'TEST' }}';
const TPAY_MERCHANT_ID = '{{ tpayMerchantId }}';
const GOOGLE_MERCHANT_ID = '{{ googleMerchantId }}';
const CURRENCY_CODE = 'PLN';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get it right from the order, however we support only PLN currency. To be determined in #73.

tests/E2E/Checkout/TpayPaymentCheckoutTest.php Outdated Show resolved Hide resolved
@coldic3 coldic3 marked this pull request as ready for review October 10, 2024 13:35
jakubtobiasz
jakubtobiasz approved these changes Oct 11, 2024
View reviewed changes
src/Api/Validator/Constraint/NotBlankIfGatewayConfigTypeEquals.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@coldic3
Introduce Google Pay type for Tpay payment method
b1a21f3
@coldic3
Handle Google Pay in order checkout page
b1d9be0
@coldic3
Save Google Pay token once generated in the checkout
1899f32
@coldic3
Fix Google Pay payment method in fixtures
8c67539
@coldic3
Add CreateGooglePayTransactionAction
f959a18
@coldic3
Add Google Pay token to PaymentDetails model
5fc570a
@coldic3
Fix BankListContextProvider to fetch channels only if Tpay payment ty…
882a043 
…pe is pay-by-link
@coldic3
Add notification security code to Google Pay in fixtures
bb65725
@coldic3
Make the Google Pay button bigger
160216b
@coldic3
Add Google Pay transaction to Mockoon
8f6c979
@coldic3
Test Google Pay transaction contract in CreateTransactionTest
83ad206
@coldic3
Add API tests for paying for orders by Google Pay
ee14f21
@coldic3
Suspend Google Pay E2E test
30dd0d3
@coldic3
Support Google Pay in API with PayByGooglePay command, handler and fa…
384e096 
…ctory
@coldic3
Introduce NotBlankIfGatewayConfigTypeEquals validation constraint
5545204
@coldic3
Validate Google Pay token in API to be JSON object encoded with Base64
5ce6d21
@coldic3
Replace redundant BlikTokenRequired and EncodedCardDataRequired valid…
316ac9c 
…ation constraints with NotBlankIfGatewayConfigTypeEquals constraint
@coldic3
Fix static analysys
344d447
@coldic3
Move EncodedGooglePayToken validator out from Api namespace
ca02992
@coldic3
Remove Google Pay E2E test that cannot be implemented properly
5f13868
@coldic3
Disable Google Pay button after successful request
8f63e00
@coldic3 coldic3 force-pushed the feature/support-google-pay-on-site branch from 6effd3c to 8f63e00 Compare October 11, 2024 13:32
@coldic3 coldic3 force-pushed the feature/support-google-pay-on-site branch from f727498 to f64a838 Compare October 11, 2024 14:11
@jakubtobiasz jakubtobiasz added enhancement New feature or request api API-related ui UI-related labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
api API-related enhancement New feature or request ui UI-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Google Pay
2 participants
@coldic3 @jakubtobiasz