Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct transfer transactions (PBL) improvements #66

Open
4 tasks done
jakubtobiasz opened this issue Oct 7, 2024 · 2 comments · May be fixed by #72
Open
4 tasks done

Direct transfer transactions (PBL) improvements #66

jakubtobiasz opened this issue Oct 7, 2024 · 2 comments · May be fixed by #72
Assignees
Labels
api API-related ui UI-related
Milestone

Comments

@jakubtobiasz
Copy link
Member

jakubtobiasz commented Oct 7, 2024

After delivering Pay by Link functionality, where we can choose a bank we want to be redirected directly, we have some improvements to be done.

Small wins 🏆

  • Caching is done via a decoration, not directly in the service [ref]
  • Creating a PBL transaction is unified and uses the same mechanisms as other types [ref]
  • New payment details data is added to our PaymentDetails model [ref]
  • PBL payment can be done via API [ref]
@jakubtobiasz jakubtobiasz added api API-related ui UI-related labels Oct 7, 2024
@jakubtobiasz jakubtobiasz added this to the 0.2 milestone Oct 7, 2024
@arti0090
Copy link
Contributor

arti0090 commented Oct 7, 2024

@jakubtobiasz the caching I have done in last commit of "parent PR" - here it is 18aaa5b

I think it should solve the first checkbox but better if you would confirm it :)

@jakubtobiasz
Copy link
Member Author

Ah, right. Missed that.

@arti0090 arti0090 linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API-related ui UI-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants