Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better way to handle TPay Logs #8

Open
jakubtobiasz opened this issue Sep 4, 2024 · 0 comments
Open

Provide better way to handle TPay Logs #8

jakubtobiasz opened this issue Sep 4, 2024 · 0 comments
Milestone

Comments

@jakubtobiasz
Copy link
Member

jakubtobiasz commented Sep 4, 2024

Currently we have a hardcoded path for Tpay logs directory. The place where we're setting it is ok (it's invoked before calling the Tpay API), but we might consider also putting it in the gateway factory right before the return statement https://github.com/CommerceWeavers/SyliusTPayPlugin/blob/d6fe3ad8923cab1393132ffae87d15e56609c490/src/Payum/Factory/TpayGatewayFactory.php#L32.

The second one might be simpler, as going the first way forces us to pass the log directory path to every \CommerceWeavers\SyliusTpayPlugin\Payum\Action\Api\BaseApiAwareAction-based service.

Once we decide where it should lay, then we need to inject the path. The path might come from:

  • parameters – the log path is already there
  • configuration

Personally, I prefer the first one.

Ref:

@jakubtobiasz jakubtobiasz added this to the 0.2 milestone Oct 2, 2024
@jakubtobiasz jakubtobiasz removed the task label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant