Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no need to introduce moshi to this project #9

Open
drakeet opened this issue Aug 21, 2022 · 2 comments
Open

There is no need to introduce moshi to this project #9

drakeet opened this issue Aug 21, 2022 · 2 comments

Comments

@drakeet
Copy link

drakeet commented Aug 21, 2022

I see that this project originally depends on gson:

api("com.google.http-client:google-http-client-gson:1.28.0")

but it also introduces moshi:

api("com.squareup.moshi:moshi:1.13.0")

The former(gson) is necessary because Google's SDK needs it, and the latter is unnecessary. I think we should remove moshi. If this is acceptable, I'd be happy to submit a PR.

Thanks!

@Jawnnypoo
Copy link
Member

Yeah, I'd be okay with removing it. We would need to change Veyron.Builder.moshi method to accept a custom Gson instance instead.

@Jawnnypoo
Copy link
Member

Feel free to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants