Skip to content

Unit Test GatewayResourceService + renamed logger #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smisidjan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unit Test GatewayResourceService + renamed logger #360

smisidjan wants to merge 2 commits into from
+363 −1

Conversation

@smisidjan
Copy link
Contributor

@smisidjan smisidjan commented Jun 21, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

👋 @smisidjan
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible. In the meanwhile make sure your PR checks the following boxes

  • Is based on an issue
  • Has been locally tested
  • Has been tested with the admin UI
  • Has been discussed with the development team in an open channel

rjzondervan
rjzondervan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rjzondervan rjzondervan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjzondervan rjzondervan rjzondervan approved these changes

@WilcoLouwerse WilcoLouwerse Awaiting requested review from WilcoLouwerse

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smisidjan @rjzondervan