Move test to inequality.rs. Add the same test for less_than.

Author: geraschenko

pumpkin-crates/core/src/constraints/arithmetic/inequality.rs

@@ -140,3 +140,38 @@ impl<Var: IntegerVariable + 'static> NegatableConstraint for Inequality<Var> {
         }
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn less_than_conflict() {
+        let mut solver = Solver::default();
+
+        let constraint_tag = solver.new_constraint_tag();
+        let x = solver.new_named_bounded_integer(0, 0, "x");
+
+        let result = less_than([x], 0, constraint_tag).post(&mut solver);
+        assert_eq!(
+            result,
+            Err(ConstraintOperationError::InfeasiblePropagator),
+            "Expected {result:?} to be an `InfeasiblePropagator` error"
+        );
+    }
+
+    #[test]
+    fn greater_than_conflict() {
+        let mut solver = Solver::default();
+
+        let constraint_tag = solver.new_constraint_tag();
+        let x = solver.new_named_bounded_integer(0, 0, "x");
+
+        let result = greater_than([x], 0, constraint_tag).post(&mut solver);
+        assert_eq!(
+            result,
+            Err(ConstraintOperationError::InfeasiblePropagator),
+            "Expected {result:?} to be an `InfeasiblePropagator` error"
+        );
+    }
+}

pumpkin-solver/tests/solver_test.rs

@@ -64,18 +64,3 @@ fn proof_with_equality_unit_nogood_step() {
     let result = solver.satisfy(&mut brancher, &mut Indefinite);
     assert!(matches!(result, SatisfactionResult::Unsatisfiable(_, _)));
 }
-
-#[test]
-fn greater_than_bug() {
-    let mut solver = Solver::default();
-
-    let constraint_tag = solver.new_constraint_tag();
-    let x = solver.new_named_bounded_integer(0, 0, "x");
-    let gt = solver.add_constraint(constraints::greater_than([x], 0, constraint_tag));
-
-    match gt.post() {
-        Err(ConstraintOperationError::InfeasiblePropagator) => {}
-        Ok(()) => panic!("expected InfeasiblePropagator when posting x > 0 for x fixed to 0"),
-        Err(e) => panic!("unexpected error: {e:?}"),
-    }
-}