From 761032b1c3acf4ed7e0791c72526a6deab51b6ea Mon Sep 17 00:00:00 2001 From: Maarten Flippo Date: Thu, 18 Sep 2025 12:31:44 +0200 Subject: [PATCH 1/5] debug environment variables --- pumpkin-solver/build.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pumpkin-solver/build.rs b/pumpkin-solver/build.rs index 54c8802f8..80085076d 100644 --- a/pumpkin-solver/build.rs +++ b/pumpkin-solver/build.rs @@ -13,6 +13,8 @@ fn run() -> Result<(), Box> { println!("cargo::rerun-if-changed=build.rs"); println!("cargo::rerun-if-env-changed=NO_CHECKERS"); + dbg!(std::env::var("NO_CHECKERS")); + if std::env::var("NO_CHECKERS") != Ok("true".to_owned()) { // If this is true, we are building the integration tests. In that case, we need // to compile the checkers. From 1fbda731676ea07ba262ee10e6a275ac2b4db2e6 Mon Sep 17 00:00:00 2001 From: Maarten Flippo Date: Thu, 18 Sep 2025 13:06:57 +0200 Subject: [PATCH 2/5] propagate NO_CHECKERS to docker container --- .github/workflows/ci-python.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 6768e91a2..92120c840 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -50,6 +50,7 @@ jobs: args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} manylinux: auto + docker-options: -e NO_CHECKERS=true - name: Upload wheels uses: actions/upload-artifact@v4 with: From 54b3479b44270eea4b044998df4ee83af4ea05fd Mon Sep 17 00:00:00 2001 From: Maarten Flippo Date: Thu, 18 Sep 2025 13:18:30 +0200 Subject: [PATCH 3/5] propagate NO_CHECKERS to docker image --- .github/workflows/ci-python.yml | 2 +- pumpkin-solver/build.rs | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 92120c840..593aa61cb 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -50,7 +50,7 @@ jobs: args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} manylinux: auto - docker-options: -e NO_CHECKERS=true + docker-options: -e NO_CHECKERS - name: Upload wheels uses: actions/upload-artifact@v4 with: diff --git a/pumpkin-solver/build.rs b/pumpkin-solver/build.rs index 80085076d..54c8802f8 100644 --- a/pumpkin-solver/build.rs +++ b/pumpkin-solver/build.rs @@ -13,8 +13,6 @@ fn run() -> Result<(), Box> { println!("cargo::rerun-if-changed=build.rs"); println!("cargo::rerun-if-env-changed=NO_CHECKERS"); - dbg!(std::env::var("NO_CHECKERS")); - if std::env::var("NO_CHECKERS") != Ok("true".to_owned()) { // If this is true, we are building the integration tests. In that case, we need // to compile the checkers. From 6ce5a44bf8a7fbdd0c7b3eed04f26e2fc7864c3c Mon Sep 17 00:00:00 2001 From: Maarten Flippo Date: Thu, 18 Sep 2025 13:19:49 +0200 Subject: [PATCH 4/5] point to the correct path that contains wheels --- .github/workflows/ci-python.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 593aa61cb..049d6a684 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -55,7 +55,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: wheels-linux-${{ matrix.platform.target }} - path: dist + path: pumpkin-solver-py/dist musllinux: runs-on: ${{ matrix.platform.runner }} @@ -87,7 +87,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: wheels-musllinux-${{ matrix.platform.target }} - path: dist + path: pumpkin-solver-py/dist windows: runs-on: ${{ matrix.platform.runner }} @@ -115,7 +115,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: wheels-windows-${{ matrix.platform.target }} - path: dist + path: pumpkin-solver-py/dist macos: runs-on: ${{ matrix.platform.runner }} @@ -142,7 +142,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: wheels-macos-${{ matrix.platform.target }} - path: dist + path: pumpkin-solver-py/dist sdist: runs-on: ubuntu-latest @@ -158,7 +158,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: wheels-sdist - path: dist + path: pumpkin-solver-py/dist release: name: Release From e839619cad89f53e6ff3b11a810c1bcd0d4ecbc1 Mon Sep 17 00:00:00 2001 From: Maarten Flippo Date: Thu, 18 Sep 2025 13:31:13 +0200 Subject: [PATCH 5/5] always publish to pypi --- .github/workflows/ci-python.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 049d6a684..edfb27dfc 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -180,7 +180,6 @@ jobs: with: subject-path: 'wheels-*/*' - name: Publish to PyPI - if: ${{ startsWith(github.ref, 'refs/tags/') }} uses: PyO3/maturin-action@v1 with: command: upload