Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get block items #80

Merged
merged 25 commits into from
Jan 25, 2024
Merged

Get block items #80

merged 25 commits into from
Jan 25, 2024

Conversation

rasmus-kirk
Copy link
Contributor

@rasmus-kirk rasmus-kirk commented Nov 28, 2023

Purpose

See #70

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Client/ConcordiumClient.cs Outdated Show resolved Hide resolved
examples/GetBlockItems/Program.cs Outdated Show resolved Hide resolved
src/Client/ConcordiumClient.cs Outdated Show resolved Hide resolved
src/Helpers/Deserialization.cs Outdated Show resolved Hide resolved
src/Transactions/BlockItem.cs Outdated Show resolved Hide resolved
src/Transactions/DeployModule.cs Show resolved Hide resolved
src/Transactions/AccountTransactionHeader.cs Outdated Show resolved Hide resolved
src/Transactions/DeployModule.cs Outdated Show resolved Hide resolved
src/Transactions/TransferWithMemo.cs Outdated Show resolved Hide resolved
@rasmus-kirk rasmus-kirk marked this pull request as ready for review December 5, 2023 14:51
@rasmus-kirk rasmus-kirk requested a review from a user December 12, 2023 08:53
src/Transactions/AccountSignatureMap.cs Show resolved Hide resolved
src/Exceptions/DeserialException.cs Show resolved Hide resolved
src/Transactions/AccountTransactionPayload.cs Outdated Show resolved Hide resolved
src/Transactions/AccountTransactionPayload.cs Show resolved Hide resolved
src/Transactions/AccountTransactionPayload.cs Show resolved Hide resolved
src/Transactions/TransferWithMemo.cs Outdated Show resolved Hide resolved
src/Transactions/UpdateInstruction.cs Show resolved Hide resolved
src/Types/OnChainData.cs Outdated Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Outdated Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Outdated Show resolved Hide resolved
src/Helpers/Deserialization.cs Outdated Show resolved Hide resolved
src/Transactions/CredentialDeployment.cs Show resolved Hide resolved
src/Transactions/Transfer.cs Outdated Show resolved Hide resolved
src/Types/OnChainData.cs Show resolved Hide resolved
src/Transactions/TransferWithMemo.cs Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Outdated Show resolved Hide resolved
src/Types/VersionedModuleSource.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only minor things left now.

src/Transactions/AccountSignatureMap.cs Show resolved Hide resolved
src/Transactions/AccountSignatureMap.cs Outdated Show resolved Hide resolved
src/Transactions/AccountSignatureMap.cs Outdated Show resolved Hide resolved
@limemloh limemloh merged commit f9be4df into main Jan 25, 2024
2 checks passed
@limemloh limemloh deleted the get-block-items branch January 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants