Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include current pool owner field in SpecialTransactionOutcome::PaydayAccountReward #26

Closed
bisgardo opened this issue Jun 13, 2022 · 2 comments
Closed

Include current pool owner field in SpecialTransactionOutcome::PaydayAccountReward #26

bisgardo opened this issue Jun 13, 2022 · 2 comments
Labels
[Type] Task An additional feature or improvement.

Comments

@bisgardo
Copy link
Contributor

bisgardo commented Jun 13, 2022 •
edited
Loading

To resolve the pool owner in a payday account reward (used in Rosetta to resolve the virtual pool accrue address from which the reward is drawn), we currently have to rely on the ordering of the special events and track this information explicitly. This is documented in the code.

See also #21 (comment) and Concordium/concordium-rosetta#24 (comment).
@bisgardo bisgardo added the [Type] Task An additional feature or improvement. label Jun 13, 2022
@bisgardo bisgardo mentioned this issue Jun 13, 2022
Merged
@limemloh
Copy link
Contributor

This sound more like it should be some helper function defined on the type rather than a field.

@limemloh limemloh mentioned this issue May 16, 2024
Open
@limemloh
Copy link
Contributor

limemloh commented May 16, 2024 •
edited
Loading

Status is now tracked in #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bisgardo @limemloh