Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the costs are correct for re-entrant calls #111

Open
3 tasks
abizjak opened this issue Jul 15, 2023 · 0 comments
Open
3 tasks

Make sure the costs are correct for re-entrant calls #111

abizjak opened this issue Jul 15, 2023 · 0 comments
Labels
[Type] Task An additional feature or improvement.

Comments

@abizjak
Copy link
Contributor

abizjak commented Jul 15, 2023

Task description

We have changed/fixed the semantics of re-entrant calls in the node in P6.

We should make sure that the costs in the testing library are correct. In particular

  • add the re-entrant tests from the node to the tests of the library
  • make sure that the library reports correct cost
  • make sure the library then also reports correct "state has changed" back to the contract.
@abizjak abizjak added the [Type] Task An additional feature or improvement. label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

1 participant