Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not recompile when change in partials #130

Closed
fwitkowski opened this issue Dec 19, 2019 · 6 comments
Closed

Does not recompile when change in partials #130

fwitkowski opened this issue Dec 19, 2019 · 6 comments
Labels

Comments

@fwitkowski
Copy link

I have scss files in /scss/ folder
In subfolder I have partials, which I @include in main.scss
When I do changes in partial file (and save them), it does not re-compile automatically,
only if I do some change in main.scss and save it.

@garrettw
Copy link
Contributor

May be a duplicate of #46. Check out what they did on that one and see if that helps you.
You might also look at #104 and #119.

@fwitkowski
Copy link
Author

Thanks this works
The only issue is I won't be able to push wp-config to staging, so if someone else will work on this site at some point, that developer would have to know to do this.

@razorfrog
Copy link

Seems like there's a new issue with the latest release 1.2.5 9 days ago. 1.2.4 worked fine on many of our sites, but 1.2.5 doesn't compile anywhere. Downgrading fixes it.
https://wordpress.org/support/topic/new-version-1-2-5-not-compiling-properly/

@imjb87
Copy link

imjb87 commented Jan 9, 2020

It's this commit that's stopped changes in imported files from triggering complication:

12e0108

To fix this issue, you need to replace this code:

new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->scss_dir), FilesystemIterator::SKIP_DOTS)

To this:

new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->scss_dir, RecursiveDirectoryIterator::SKIP_DOTS))

on lines 156. There's also another line very similar on 166:

new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->css_dir), FilesystemIterator::SKIP_DOTS)

Needs changing to:

new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->css_dir, RecursiveDirectoryIterator::SKIP_DOTS))

@shadoath
Copy link
Collaborator

Taking over the maintenance of this plugin. The creators did not have time to work on it. Now, i'm looking at the backlog of issues and working to solve them. @johntbb, thank you for pointing out the solution. I have a PR with updates you can look at.

@shadoath shadoath added the bug label Feb 15, 2021
@shadoath
Copy link
Collaborator

I believe this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants