Request: Allow WP-SCSS Cache dir change #197
Labels
Comments
|
Open to a PR for this. Otherwise it will need to wait til I have time for implementing this change. |
|
Hello, are you still open to a PR for this feature? I may be able to set one up for your consideration. |
matt-bernhardt
added a commit
to matt-bernhardt/WP-SCSS
that referenced
this issue
Oct 18, 2022
** Why are these changes being introduced: * Some environments deny plugins the ability to create and maintain a cache internally, but other locations (like the uploads directory) may be okay. * The plugin already allows the ability to configure the scss and css folders, so perhaps the cache directory could be treated similarly. ** Relevant ticket(s): * ConnectThink#197 ** How does this address that need: * This attempts to handle the cache directory in a similar fashion to the scss and css directory, leveraging the work already done to move those locations according to user preferences. ** Document any side effects to this change: * I'm hoping none, but I'm still learning the internals of this plugin. * The Wp_Scss class uses `cache` instead of `cache_dir`, while the other folders are named `scss_dir` and `css_dir`. I've opted to leave these names intact to try and make the smallest possible change, but this may be a mistake.
|
@matt-bernhardt Yes, put something together and I'll review it. |
|
Please pull down the current |
matt-bernhardt
added a commit
to matt-bernhardt/WP-SCSS
that referenced
this issue
Oct 18, 2022
** Why are these changes being introduced: * Some environments deny plugins the ability to create and maintain a cache internally, but other locations (like the uploads directory) may be okay. * The plugin already allows the ability to configure the scss and css folders, so perhaps the cache directory could be treated similarly. ** Relevant ticket(s): * ConnectThink#197 ** How does this address that need: * This attempts to handle the cache directory in a similar fashion to the scss and css directory, leveraging the work already done to move those locations according to user preferences. ** Document any side effects to this change: * The Wp_Scss class uses `cache` instead of `cache_dir`, while the other folders are named `scss_dir` and `css_dir`. I've opted to leave these names intact to try and make the smallest possible change, but this may be a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I have a request related to cache dir location. May I ask you to add a way to allow us WP admins to edit the location of WP-SCSS cache dir? I am not a big fan of having cache dirs inside plugin itself. It would be great if we can override the default location. It could be with some special variable, if is defined then to use that path or backend setting, but I think that probably easiest and fastest is with checking if some constant var is set that define the path.
Thank you in advance!
Best regards,
Ali Nebi
The text was updated successfully, but these errors were encountered: