Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 84a114c

Browse files
committed
Fix issue where --follow fails with unhelpful error message, if the log file does not exist
1 parent d653a15 commit 84a114c

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

src/packages/cli/src/cli.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,10 @@ if (argv.action === "start") {
188188

189189
stream.on("error", err => {
190190
if ((err as NodeJS.ErrnoException).code === "ENOENT") {
191-
console.log(
192-
`No logs are available for ${instanceName}.\nTry calling some RPC methods.`
191+
console.error(
192+
`No logs found for ${porscheColor(
193+
instanceName
194+
)}. The log file may have been deleted.\n\nYou may need to restart the instance.`
193195
);
194196
}
195197
});

src/packages/cli/src/logs-stream.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -107,19 +107,10 @@ export function createFollowReadStream(filename: string): Readable {
107107
watcher.close();
108108
createStream();
109109
});
110-
});
110+
})
111+
.on("error", err => followStream.emit("error", err));
111112
}
112113
createStream();
113114

114115
return followStream;
115116
}
116-
117-
function readFromBuffers(buffers: Buffer[], size?: number) {
118-
const entireBuffer = Buffer.concat(buffers.splice(0, buffers.length));
119-
if (size == undefined || size <= entireBuffer.length) {
120-
return entireBuffer;
121-
} else {
122-
buffers.push(entireBuffer.slice(size + 1));
123-
return entireBuffer.slice(0, size);
124-
}
125-
}

0 commit comments

Comments
 (0)