Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHF module - missing byte constraints? #164

Open
booleanfunction opened this issue May 10, 2024 · 2 comments
Open

SHF module - missing byte constraints? #164

booleanfunction opened this issue May 10, 2024 · 2 comments

Comments

@booleanfunction
Copy link

booleanfunction commented May 10, 2024

SHB_3_HI, … SHB_7_LO have byte constraints in the spec but not in Corset

Should they all be :byte@prove?

@letypequividelespoubelles
Copy link
Collaborator

I think we should release the bytehood constraint in the spec, as their values are explicitly define from (byte) values from the lookup ref table @OlivierBBB

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented May 14, 2024

In this precise case these constraints aren't needed since, if I remember correctly, SHB_3_HI is constructed manually from input bytes and lookup'd values and the remaining columns (SHB_4_LO, …, SHB_7_LO) are obtained from one another by moving stuff around --- stuff that is already known to be bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants