[BUG] Set Host header to match target host in proxied requests #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the HTTP
Hostheader is correctly set to match the target ClickHouse server's host when proxying requests. Previously, theHostheader could retain the original proxy address, which could cause issues with host routing or server-side host validation.According to the HTTP specification:
MDN - Host Header
RFC 9110 Section 7.2
Real-world impact:
The incorrect
Hostheader can cause issues in environments using host routing, such as AWS Application Load Balancers with host-based routing rules, where requests are routed based on theHostheader value.Example scenario from issue #415:
Before
After
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments
Fixes: #415