Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to change port for alarm logger #3107

Open
minijackson opened this issue Aug 7, 2024 · 5 comments
Open

Document how to change port for alarm logger #3107

minijackson opened this issue Aug 7, 2024 · 5 comments
Assignees

Comments

@minijackson
Copy link
Contributor

Not long ago, I fell into a rabbit hole on why my server.port property was not recognized by Phoebus alarm logger.

After a while, I found out that it's because the -properties /path/to/config.properties argument doesn't forward the loaded properties to SpringBoot. So my solution was to also specify the environment variable SPRING_CONFIG_IMPORT=/path/to/config.properties.

It would be nice if there was an official, documented way of doing this, as port 8080 is used by quite a number of EPICS-related services by default.

@minijackson
Copy link
Contributor Author

I found #2277 (comment) recently, but as far as I know the -Dserver.port argument is not documented on the Phoebus documentation, and it might get quite annoying if one wants to modify other SpringBoot settings.

@shroffk shroffk self-assigned this Aug 7, 2024
@kasemir
Copy link
Collaborator

kasemir commented Aug 7, 2024

Yes, SpringBoot adds too many dependencies and obfuscates the configuration. We should remove it and have all services use a plain "main()" like the alarm server, scan server, RDB archive engine

@shroffk
Copy link
Member

shroffk commented Aug 7, 2024

Umm... There are quite a few other benefits of springboot, we are trying to merge 2 startup and configuration processes here which has resulted in some issues. I will look into cleaning it up.

@kasemir
Copy link
Collaborator

kasemir commented Aug 7, 2024

Nah, it's a complex framework just like Eclipse was. It expects you to know which annotations to add and where to place files without a way to follow breadcrumbs or call trees. In ~4 years there'll be a springboot update that forces you re-do everything.

@georgweiss
Copy link
Collaborator

georgweiss commented Aug 7, 2024

We should make all services Spring Boot-based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants