Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint fix #65

Open
ucwong opened this issue Jul 18, 2020 · 5 comments
Open

golint fix #65

ucwong opened this issue Jul 18, 2020 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ucwong
Copy link
Member

ucwong commented Jul 18, 2020

Fix golint warnings, it is a good way to review code
https://github.com/golang/lint

3a4eeb6

@ucwong ucwong added the good first issue Good for newcomers label Jul 18, 2020
@ShadowErii
Copy link

should we do exactly as it suggest?

@ucwong
Copy link
Member Author

ucwong commented Jul 18, 2020

should we do exactly as it suggest?

If it doesn't cause build and logic error, it is better to follow golint style.
You can try some simple files first

@ShadowErii
Copy link

ShadowErii commented Jul 18, 2020

should we do exactly as it suggest?

If it doesn't cause build and logic error, it is better to follow golint style.
You can try some simple files first

for example,should we move the all "package ..." statement ahead of package comment,which I don't think is a good idea

@ucwong
Copy link
Member Author

ucwong commented Jul 18, 2020

should we do exactly as it suggest?

If it doesn't cause build and logic error, it is better to follow golint style.
You can try some simple files first

for example,should we move the all "package ..." statement ahead of package comment,which I don't think is a good idea

This can be ignored, you can focus on logic code style , func and var define

@ShadowErii
Copy link

got it :)

@ShadowErii ShadowErii linked a pull request Jul 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants