From d40bcc6c8d7760452ba2f498d70d8c24a94ed66e Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray Date: Fri, 20 Dec 2024 15:58:52 +0300 Subject: [PATCH 1/4] fix: 35 action bar issue --- CHANGELOG.md | 3 +++ .../main/java/ly/count/android/sdk/TransparentActivity.java | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9146bef2..ffbc8b6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +## XX.XX.XX +* Mitigated an issue where, on Android 35 and above, the action bar was overlapping with the content display. + ## XX.XX.XX * Added a config option to content (setZoneTimerInterval) to set content zone timer. (Experimental!) diff --git a/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java b/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java index b18ebcac..92d50b91 100644 --- a/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java +++ b/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java @@ -41,6 +41,12 @@ public class TransparentActivity extends Activity { @Override protected void onCreate(Bundle savedInstanceState) { Log.d(Countly.TAG, "[TransparentActivity] onCreate, content received, showing it"); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) { + // For android 35 and above there is a stripe at the top of the screen for contents + // we eliminate it with no action bar full screen and this adds more smoothness + // the stripe is because of our transparency + setTheme(android.R.style.Theme_DeviceDefault_NoActionBar_Fullscreen); + } super.onCreate(savedInstanceState); overridePendingTransition(0, 0); From d847212f8475f2577f29d5167b5eeb53b09a4580 Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray <57103426+arifBurakDemiray@users.noreply.github.com> Date: Fri, 10 Jan 2025 16:12:02 +0300 Subject: [PATCH 2/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ffbc8b6b..7450a1f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ ## XX.XX.XX -* Mitigated an issue where, on Android 35 and above, the action bar was overlapping with the content display. +* Mitigated an issue where, the action bar was overlapping with the content display. ## XX.XX.XX * Added a config option to content (setZoneTimerInterval) to set content zone timer. (Experimental!) From eb3aa91e7480053a481e6122bfc27cdabe9cf24a Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray <57103426+arifBurakDemiray@users.noreply.github.com> Date: Fri, 10 Jan 2025 16:12:37 +0300 Subject: [PATCH 3/4] Update TransparentActivity.java --- .../ly/count/android/sdk/TransparentActivity.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java b/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java index 92d50b91..0b9c42e8 100644 --- a/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java +++ b/sdk/src/main/java/ly/count/android/sdk/TransparentActivity.java @@ -41,12 +41,11 @@ public class TransparentActivity extends Activity { @Override protected void onCreate(Bundle savedInstanceState) { Log.d(Countly.TAG, "[TransparentActivity] onCreate, content received, showing it"); - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) { - // For android 35 and above there is a stripe at the top of the screen for contents - // we eliminate it with no action bar full screen and this adds more smoothness - // the stripe is because of our transparency - setTheme(android.R.style.Theme_DeviceDefault_NoActionBar_Fullscreen); - } + + // there is a stripe at the top of the screen for contents + // we eliminate it with no action bar full screen and this adds more smoothness + // the stripe is because of our transparency + setTheme(android.R.style.Theme_DeviceDefault_NoActionBar_Fullscreen); super.onCreate(savedInstanceState); overridePendingTransition(0, 0); From f21803ebeb11565f087775f5455603b36d96fe6b Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray <57103426+arifBurakDemiray@users.noreply.github.com> Date: Mon, 13 Jan 2025 10:17:07 +0300 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7450a1f4..7ccbc1aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ ## XX.XX.XX * Mitigated an issue where, the action bar was overlapping with the content display. -## XX.XX.XX +## 24.7.8 * Added a config option to content (setZoneTimerInterval) to set content zone timer. (Experimental!) ## 24.7.7