Skip to content

Commit 647e904

Browse files
committed
Fix disabling single navidrome server
1 parent 339d3db commit 647e904

File tree

3 files changed

+20
-14
lines changed

3 files changed

+20
-14
lines changed

app/src/main/java/com/craftworks/music/managers/NavidromeManager.kt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,19 @@ object NavidromeManager {
4242
saveServers()
4343
}
4444

45-
fun setCurrentServer(id: String) {
46-
if (id in servers) {
47-
currentServerId = id
48-
} else {
49-
throw IllegalArgumentException("Server with id $id not found")
50-
}
45+
fun setCurrentServer(id: String?) {
46+
// if (id in servers) {
47+
// currentServerId = id
48+
// } else {
49+
// throw IllegalArgumentException("Server with id $id not found")
50+
// }
51+
52+
currentServerId = id
5153
saveServers()
5254
}
5355

5456
fun checkActiveServers(): Boolean {
55-
return servers.keys.isNotEmpty() || currentServerId != null
57+
return servers.keys.isNotEmpty() && currentServerId != null
5658
}
5759

5860
fun getAllServers(): List<NavidromeProvider> = servers.values.toList()

app/src/main/java/com/craftworks/music/providers/local/LocalProvider.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,16 @@ class LocalProvider private constructor() {
8282
}
8383

8484
else -> {
85-
val idColumn: Int = cursor.getColumnIndexOrThrow(MediaStore.Audio.Media._ID)
86-
val albumColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.ALBUM)
87-
val artistColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.ARTIST)
85+
val idColumn: Int = cursor.getColumnIndexOrThrow(MediaStore.Audio.Albums._ID)
86+
val albumColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Albums.ALBUM)
87+
val artistColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Albums.ARTIST)
8888
//val dateAddedColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.DATE_ADDED)
8989
//val yearColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.YEAR)
9090

9191
do {
9292
val thisId = cursor.getLongOrNull(idColumn) ?: 0
93-
val thisAlbum = cursor.getString(albumColumn)
94-
val thisArtist = cursor.getString(artistColumn)
93+
val thisAlbum = cursor.getStringOrNull(albumColumn) ?: "Unknown"
94+
val thisArtist = cursor.getStringOrNull(artistColumn) ?: "Unknown"
9595
//val thisDateAdded = cursor.getString(dateAddedColumn)
9696
//val thisYear = cursor.getInt(yearColumn)
9797

@@ -169,7 +169,7 @@ class LocalProvider private constructor() {
169169
else -> {
170170
val idColumn: Int = cursor.getColumnIndexOrThrow(MediaStore.Audio.Media._ID)
171171
val albumColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.ALBUM)
172-
val artistColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.ARTIST)
172+
val artistColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Albums.ARTIST)
173173
val artistIdColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Albums.ARTIST_ID)
174174
val yearColumn: Int = cursor.getColumnIndex(MediaStore.Audio.Media.YEAR)
175175

app/src/main/java/com/craftworks/music/ui/elements/ProviderCard.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,12 @@ fun NavidromeProviderCard(server: NavidromeProvider = NavidromeProvider("0","htt
191191
NavidromeManager.setCurrentServer(server.id)
192192
GlobalViewModels.refreshAll()
193193
}
194+
else {
195+
NavidromeManager.setCurrentServer(null)
196+
GlobalViewModels.refreshAll()
197+
}
194198
// Update checked
195-
checked = (server.id == NavidromeManager.getCurrentServer()?.id)
199+
//checked = (server.id == NavidromeManager.getCurrentServer()?.id)
196200
}
197201
)
198202
}

0 commit comments

Comments
 (0)