Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split datagen into api and Create's actual datagen #7366

Open
ChiefArug opened this issue Feb 23, 2025 · 0 comments
Open

Split datagen into api and Create's actual datagen #7366

ChiefArug opened this issue Feb 23, 2025 · 0 comments

Comments

@ChiefArug
Copy link

Currently datagen is a bit of a mix of stuff that should be API so that addons can utilise it and Create's actual datagen. This should be split up so it both easier for addons to use datagen and so it is clear how addons should use create's datagen.

This should be done by moving all of the currently abstract datagen classes to api (ie ProcessingRecipeGen, CreateRecipeProvider), and moving static methods from there like ProcessingRecipeGen#registerAll into another class. The current concrete implementations such as MillingRecipeGen should be split into an abstract class (with the useful helper methods) for addons to use (ie MillingRecipeGen) and a concrete class that create actually uses for its generation (ie CreateMillingRecipeGen and with the create specific helper methods). This should also be combined with making those concrete classes final as an extra nudge for addons to not use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant