From e477f622ef3173a050653fc0a780b9d913a0b1ea Mon Sep 17 00:00:00 2001 From: Kelly Selden Date: Tue, 3 Sep 2024 10:36:57 -0700 Subject: [PATCH] Revert "chore: hardcode edgedriver version in CI" This reverts commit 3cab2b424e364300fe6ffebc12d51928f346e96c. --- .github/workflows/ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f0931fd97..e62704386 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,7 @@ on: env: DEBUG: "@faltest*,faltest-helpers" DETECT_CHROMEDRIVER_VERSION: true + DETECT_EDGEDRIVER_VERSION: true jobs: lint-git: @@ -63,8 +64,6 @@ jobs: # - uses: browser-actions/setup-edge@latest - run: yarn install --frozen-lockfile - env: - EDGEDRIVER_VERSION: 128.0.2739.56 - run: yarn test env: WEBDRIVER_HEADLESS: true @@ -90,8 +89,6 @@ jobs: node-version: ${{ matrix.node }} - run: yarn install --frozen-lockfile - env: - EDGEDRIVER_VERSION: ${{ matrix.os == 'ubuntu-latest' && '128.0.2739.56' || matrix.os == 'macos-latest' && '128.0.2739.61' || '128.0.2739.54' }} - if: runner.os == 'Linux' # https://github.com/juliangruber/browser-run/issues/147#issue-495226343 run: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &