[188532827]: deprecate setting derivation after variable is created

Author: gergness

R/variable-derivation.R

@@ -123,6 +123,11 @@ setMethod("derivation<-", c("CrunchVariable", "ANY"), function(x, value) {
 # silently takes and discards `value` to make method dispatch easier
 integrateDerivedVar <- function(x, value) {
     if (is.derived(x)) {
+        warn_once(paste0(
+            "Materializing an existing derived variable is deprecated and will not work in the future. ",
+            "Prefer setting `derived=FALSE` when creating a variable over changing it later."
+        ), option = "warnIntegrateDerivedVar")
+
         payload <- toJSON(list(derived = FALSE))
         crPATCH(self(x), body = payload)
 

tests/testthat/test-derive.R

@@ -48,10 +48,14 @@ with_mock_crunch({
     })
 
     test_that("derivation()<-NULL and is.derived()<-FALSE issues a PATCH", {
-        expect_PATCH(
-            derivation(birthyrPlus) <- NULL,
-            "https://app.crunch.io/api/datasets/1/variables/birthyrPlus/",
-            '{"derived":false}'
+        set_crunch_opts("warnIntegrateDerivedVar" = FALSE)
+        expect_warning(
+            expect_PATCH(
+                derivation(birthyrPlus) <- NULL,
+                "https://app.crunch.io/api/datasets/1/variables/birthyrPlus/",
+                '{"derived":false}'
+            ),
+            "Materializing an existing derived variable is deprecated"
         )
         expect_PATCH(
             is.derived(birthyrPlus) <- FALSE,