Consolidate arguments to a Patroni function #4057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When called at runtime, the second argument is always derived from the first. This simplifies those call sites and clarifies the behavior in tests.
cbandy
commented
Dec 19, 2024
Comment on lines
858
to
+862
| "postgresql": map[string]any{ | ||
| "bin_name": map[string]any{"pg_rewind": string("/tmp/pg_rewind_tde.sh")}, | ||
| "parameters": map[string]any{}, | ||
| "bin_name": map[string]any{"pg_rewind": string("/tmp/pg_rewind_tde.sh")}, | ||
| "parameters": map[string]any{ | ||
| "encryption_key_command": "echo test", | ||
| }, |
Member
Author
There was a problem hiding this comment.
📝 Here's where the expection changed.
tjmoore4
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called at runtime, the second argument is always derived from the first. This simplifies those call sites and clarifies the behavior in tests.
Checklist:
Type of Changes: