Safari/Firefox pipelines & all screenshots removed

Author: VladimirPodolian

.github/workflows/playwright_tests.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   playwright-docker:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
 
     strategy:
       fail-fast: false
@@ -43,6 +43,6 @@ jobs:
         run: |
           echo "HOME=/root" >> $GITHUB_ENV  # Set HOME environment variable
 
-      - name: Run Playwright ${{ matrix.browser-name }} on py${{ matrix.python-version }} tests
+      - name: Run Playwright ${{ matrix.browser-name }} tests with py${{ matrix.python-version }}
         run: |
           tox -e py${{ env.TOX_ENV }}-playwright-${{ matrix.browser-name }} -- --headless -v --sv

.github/workflows/selenium_safari_tests.yml

@@ -0,0 +1,38 @@
+name: Selenium Safari Tests
+
+on:
+  push:
+    branches:
+      - '**'  # Trigger on push to any branch
+
+jobs:
+  selenium-safari:
+    runs-on: macos-13
+
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: [ "3.8", "3.12" ]
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.8'
+
+      - name: Setup tests
+        run: |
+          python -m pip install --upgrade pip
+          pip install tox==3.28.0
+          
+      - name: Extract tox env
+        run: |
+          tox_env_variable=$(echo "${{ matrix.python-version }}" | sed 's/\.//g')
+          echo "TOX_ENV=${tox_env_variable}" >> $GITHUB_ENV
+
+      - name: Run Selenium Safari tests with py${{ matrix.python-version }}
+        run: |
+          tox -e py${{ env.TOX_ENV }}-selenium-safari -- --headless -v --sv

.github/workflows/selenium_tests.yml

@@ -7,11 +7,17 @@ on:
 
 jobs:
   selenium-selenoid:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
+
+    strategy:
+      fail-fast: false
+      matrix:
+        image: [ "selenoid/chrome:128.0", "selenoid/firefox:125.0"]
+        python-version: [ "3.8", "3.12" ]
 
     services:
       selenoid:
-        image: selenoid/vnc:chrome_112.0
+        image: ${{ matrix.image }}
         options: --privileged --memory=4g
         ports:
           - 4444:4444
@@ -29,7 +35,17 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           pip install tox==3.28.0
+      
+      - name: Extract tox env
+        run: |
+          tox_env_variable=$(echo "${{ matrix.python-version }}" | sed 's/\.//g')
+          echo "TOX_ENV=${tox_env_variable}" >> $GITHUB_ENV
+
+      - name: Extract Browser Name
+        run: |
+          browser_name=$(echo "${{ matrix.image }}" | sed -E 's|.*/([^:]+):.*|\1|')
+          echo "BROWSER=${browser_name}" >> $GITHUB_ENV
 
-      - name: Run Selenium tests
+      - name: Run Selenium ${{ env.BROWSER }} tests with py${{ matrix.python-version }}
         run: |
-          tox -e py38-selenium-chrome -- --env remote --headless -v --sv
+          tox -e py${{ env.TOX_ENV }}-selenium-${{ env.BROWSER }} -- --env remote --headless -v

.github/workflows/static_tests.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   static:
-    runs-on: ubuntu-latest  #'windows-latest' / 'macos-latest'
+    runs-on: ubuntu-24.04
 
     strategy:
       fail-fast: false
@@ -33,6 +33,6 @@ jobs:
           tox_env_variable=$(echo "${{ matrix.python-version }}" | sed 's/\.//g')
           echo "TOX_ENV=${tox_env_variable}" >> $GITHUB_ENV
 
-      - name: Run Tox on ${{ matrix.python-version }}
+      - name: Run Static tests with ${{ matrix.python-version }}
         run: |
           tox -e py${{ env.TOX_ENV }}-static

tests/adata/drivers/selenium_driver.py

@@ -15,16 +15,25 @@ class SeleniumDriver:
     @staticmethod
     def create_selenium_driver(entities: DriverEntities):
         driver_name = entities.driver_name
+        options = None
+        remote_url = "http://127.0.0.1:4444"
+
         if driver_name == 'safari' and DriverWrapperSessions.is_connected():
             driver_name = 'chrome'  # Cannot create second selenium driver
-
+        elif driver_name == 'chrome':
+            options = entities.selenium_chrome_options
+        elif driver_name == 'firefox':
+            options = entities.selenium_firefox_options
+            remote_url += '/wd/hub'
+        else:
+            raise Exception('Unknown driver: %s' % driver_name)
 
         if entities.env == 'remote':
-            driver = Remote(options=entities.selenium_chrome_options)
+            driver = Remote(remote_url, options=options)
         elif driver_name == 'chrome':
-            driver = ChromeWebDriver(options=entities.selenium_chrome_options, service=ChromeService())
+            driver = ChromeWebDriver(options=options, service=ChromeService())
         elif driver_name == 'firefox':
-            driver = GeckoWebDriver(options=entities.selenium_firefox_options, service=FirefoxService())
+            driver = GeckoWebDriver(options=options, service=FirefoxService())
         elif driver_name == 'safari':
             driver = SafariWebDriver(service=SafariService())
         else: