Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUSH0 issues raised while hardfork is set to Paris explicitly #547

Open
RensR opened this issue Jun 20, 2024 · 1 comment
Open

PUSH0 issues raised while hardfork is set to Paris explicitly #547

RensR opened this issue Jun 20, 2024 · 1 comment
Labels
priority-low Low priority issue

Comments

@RensR
Copy link
Contributor

RensR commented Jun 20, 2024

PUSH0 is not supported by all chains

To Reproduce
Steps to reproduce the behavior:

  1. Clone repo: https://github.com/smartcontractkit/ccip
  2. Run aderyn with this foundry profile ccip

Expected behavior
Since the Paris hardfork is set in foundry.toml I would not expect to see PUSH0 related issues being raised.

@alexroan
Copy link
Contributor

I think the appropriate way to approach this is to accept this as a flag in aderyn, then auto-parse from famous files like foundry.toml or aderyn.toml.

We would then need to build a framework for registering detectors with applicable hardfork versions. Given that this detector is the only one that identifies an issue that changed depending on hardfork version, and node Solidity code, I'm inclined to punt this issue out as "Future Feature", and maybe sunset this detector.

@alexroan alexroan added the priority-low Low priority issue label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants