-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include compatibility range in the readme #12
Comments
I agree that the add-on is not compatible with NVDA 2024.1 since I have not updated the manifest, on purpose. Since I have made the choice to release only stable versions of this add-on, and since the documentation that you are quoting is extracted from a stable version, you cannot expect (yet) the add-on to be compatible with NVDA 2024.1 since NVDA 2024.1 is still in beta testing phase. In the add-on's change log, I have written:
That means that I prepare the compatibility code, but I do not yet claim to be compatible with NVDA 2024.1 since the API may still change during NVDA beta phase, thought unlikely.
I agree that writing the following is not very precise:
Actually, it indicates the first compatible version but does not give the last compatible version. I prefer do this way anyway, because it's still an information that may be useful, e.g. on the community website or in the add-on. So for now, I'll keep the documentation as is. I close this issue. But feel free to comment if you disagree and I may reopen. |
In the readme of this add-on, we can see the following information:
This suggest that this add-on is compatible with all versions beyond 2022.3.3, but in fact it's not compatible with NVDA 2024.1beta versions, since the manifest.ini doesn't specify this version.
Since in the store we can see the last version of each add-on which is compatible with the running version of NVDA for the selected channel, the easiest option (and my strategy) is omitting the compatibility range in the readme. Another strategy maybe to reflect the compatibility in the documentation for each version, but this maybe burden and maybe confusing if a new breaking compatibility API version is published for NVDA, @CyrilleB79 .
I'm creating this issue, as requested in nvaccess/addon-datastore#2483
The text was updated successfully, but these errors were encountered: