Skip to content

Commit 8e355d2

Browse files
authored
fix(api): mapping filter condition (keephq#1035)
1 parent 6504588 commit 8e355d2

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

keep/api/routes/mapping.py

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@
55

66
from keep.api.core.db import get_session
77
from keep.api.core.dependencies import AuthenticatedEntity, AuthVerifier
8-
from keep.api.models.db.mapping import MappingRule, MappingRuleDtoIn, MappingRuleDtoOut, MappingRuleDtoUpdate
8+
from keep.api.models.db.mapping import (
9+
MappingRule,
10+
MappingRuleDtoIn,
11+
MappingRuleDtoOut,
12+
MappingRuleDtoUpdate,
13+
)
914

1015
router = APIRouter()
1116

@@ -82,12 +87,20 @@ def delete_rule(
8287

8388

8489
@router.put("", description="Update an existing rule")
85-
def update_rule(rule: MappingRuleDtoUpdate,
86-
authenticated_entity: AuthenticatedEntity = Depends(AuthVerifier(["write:rules"])),
87-
session: Session = Depends(get_session)) -> MappingRuleDtoOut:
90+
def update_rule(
91+
rule: MappingRuleDtoUpdate,
92+
authenticated_entity: AuthenticatedEntity = Depends(AuthVerifier(["write:rules"])),
93+
session: Session = Depends(get_session),
94+
) -> MappingRuleDtoOut:
8895
logger.info("Updating a mapping rule")
89-
existing_rule: MappingRule = session.query(MappingRule).filter(
90-
MappingRule.tenant_id == authenticated_entity.tenant_id and MappingRule.id == rule.id).first()
96+
existing_rule: MappingRule = (
97+
session.query(MappingRule)
98+
.filter(
99+
MappingRule.tenant_id == authenticated_entity.tenant_id,
100+
MappingRule.id == rule.id,
101+
)
102+
.first()
103+
)
91104
if existing_rule is None:
92105
raise HTTPException(status_code=404, detail="Rule not found")
93106
existing_rule.name = rule.name
@@ -102,6 +115,6 @@ def update_rule(rule: MappingRuleDtoUpdate,
102115
response = MappingRuleDtoOut(**existing_rule.dict())
103116
if rule.rows is not None:
104117
response.attributes = [
105-
key for key in existing_rule.rows[0].keys() if key not in rule.matchers
106-
]
118+
key for key in existing_rule.rows[0].keys() if key not in rule.matchers
119+
]
107120
return response

0 commit comments

Comments
 (0)