Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to git blame ignore file #1090

Open
skrawcz opened this issue Aug 9, 2024 · 2 comments
Open

Add to git blame ignore file #1090

skrawcz opened this issue Aug 9, 2024 · 2 comments

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Aug 9, 2024

This is a placeholder issue so that we hide the reformatting commits on changing to ruff.

Some commits here we should hide:

TODO:

  • add list of PRs that are reformatting based
  • once complete, compile list of commits and update that ignore file.
@zilto
Copy link
Collaborator

zilto commented Aug 9, 2024

Also, we should be able to cleanup config files such as /.flake8 if we're now using Ruff and linting is specified in pyproject.toml

@Dev-iL
Copy link
Contributor

Dev-iL commented Aug 10, 2024

Also, we should be able to cleanup config files such as /.flake8 if we're now using Ruff and linting is specified in pyproject.toml

That's indeed the plan after we finish configuring ruff to run a superset of flake8 inspections. I couldn't guarantee that this was the case, so kept flake8 temporarily.

(Btw, flake8 cannot be configured via pyproject, its configs were very recently moved from setup.cfg to the file you mentioned.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants