Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivf中Computer的metric直接传入this->metric_type_就可以吧，有必要用模板吗？ #14

Open
DittoWii opened this issue Apr 7, 2024 · 1 comment
Open

ivf中Computer的metric直接传入this->metric_type_就可以吧，有必要用模板吗？ #14

DittoWii opened this issue Apr 7, 2024 · 1 comment

Comments

@DittoWii
Copy link
Contributor

DittoWii commented Apr 7, 2024

因为每个index自带了初始化时候的metric类型，直接使用index里存的数据应该就可以？
@BenjaminXiang
Copy link
Collaborator

用模板的考虑是可以在编译期就确定 Computer 的计算函数具体是什么,期望把更多需要在运行时确定的内容放在编译期从而减少在运行时构造 Computer 的开销. 目前ivf Computer 的 metric 模板在使用的时候有一个 Bug,我昨天尝尽进行了修复,今天测试完没有问题后会进行更新.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenjaminXiang @DittoWii