Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staging] Neon should check if clef has invalid @line #1251

Open
3 tasks
yinanazhou opened this issue Dec 6, 2024 · 1 comment
Open
3 tasks

[Staging] Neon should check if clef has invalid @line #1251

yinanazhou opened this issue Dec 6, 2024 · 1 comment

Comments

@yinanazhou
Copy link
Member

yinanazhou commented Dec 6, 2024

Recent MEI files have clefs that have invalid @line attribute.

Expected behaviour:

  • Neon should give notification about it and provide @mei:id
  • Neon should have new MEI action that can fix it
  • MEI encoding job in Rodan should be fixed regarding this
@yinanazhou yinanazhou changed the title [ [Staging] Neon should check if clef has @line Dec 6, 2024
@yinanazhou
Copy link
Member Author

yinanazhou commented Dec 18, 2024

Hi @JoyfulGen and @annamorphism, I noticed that Rodan produces clefs with invalid line. In MEI, the value must be in the range between 1 and the number of lines on the staff. But I've found straight outta OMR files have clefs with line equals to 0 or 5. I wonder what is the best way to fix this. We have two options for the MEI action:

  1. remove the invalid clefs
  2. modify the value, so that all values below 1 would be changed to 1, and all values above 4 would be changed to 4

Which one would you prefer?

@yinanazhou yinanazhou changed the title [Staging] Neon should check if clef has @line [Staging] Neon should check if clef has invalid @line Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant