Recurring payment terms and conditions page #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3667 Terms and conditions page for recurring payments
jaucourt
approved these changes
Jan 23, 2024
| ])('back button tests for $handlerName page', ({ pageHandler }) => { | ||
| it.each([[CONTROLLER.uri], [RECURRING_TERMS_CONDITIONS.uri]])( | ||
| 'addLanguageCodeToUri is called with %s when referrer is %s', | ||
| async referer => { |
There was a problem hiding this comment.
You've spelt referrer correctly in the description, but wrong here. I almost let you off because it's [misspelt in the http spec](https://privacyinternational.org/guide-step/4150/http-referer-explanation#:~:text=What%3A%20the%20Referer%20(a%20misspelling,request%20received%20by%20a%20server.), but it jars too much, sorry!
| @@ -283,7 +326,7 @@ describe('guidance page handlers', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| const getMockRequest = (i18nValues, search = '') => { | |||
| const getMockRequest = (i18nValues, referer) => { | |||
There was a problem hiding this comment.
It's ok here because it leads to more concise code!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3667
Terms and conditions page for recurring payments