-
Notifications
You must be signed in to change notification settings - Fork 55
Open
Labels
Description
When selecting the periodic boundary condition, dip::Skew() produces an output of the same size as the input, but dip::Rotation() expects the image size to grow. The assert DIP_ASSERT( shiftOrigin1 ) on line 539 and the assert DIP_ASSERT( shiftOrigin2 ) on line 553 are not always satisfied. With asserts disabled, the code can write out of bounds.
Strangely enough, I remember this working at some point in the past, there is even a note in the documentation for dip::Rotation() warning about the unexpected output size when using the periodic boundary condition. I'm guessing it started to fail when I fixed the issue of the image origin not always being preserved (a423d06).
I'll make the rotation fail with this boundary condition for now.
Reactions are currently unavailable