Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Commit 26c272d

Browse files
author
Marko Petric
authored
Merge pull request #123 from chaen/upgradeXrootGfal2
Upgrade xroot gfal2
2 parents cbc0162 + ab3d639 commit 26c272d

File tree

7 files changed

+70
-35
lines changed

7 files changed

+70
-35
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ DIRACOS aims at bringing in one archive all the dependencies needed by DIRAC to
4444
* [ Singularity](docs/50_troubleshoot.md#singularity)
4545
* [ About manualDependencies](docs/50_troubleshoot.md#about-manualdependencies)
4646
* [ LDD check failing](docs/50_troubleshoot.md#ldd-check-failing)
47+
* [ldconfig_scriptlets](docs/50_troubleshoot.md#ldconfig_scriptlets)
4748
- [ Test DIRACOS as a User](docs/60_useDIRACOS.md#test-diracos-as-a-user)
4849
- [ Make a new release](docs/70_release.md#make-a-new-release)
4950
* [ Versioning](docs/70_release.md#versioning)

config/diracos.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,8 +453,9 @@
453453
"buildOnly": true
454454
},
455455
{
456-
"src": "https://diracos.web.cern.ch/diracos/SRPM/xrootd-4.10.0-1.el7.src.rpm",
456+
"src": "https://diracos.web.cern.ch/diracos/SRPM/xrootd-4.11.2-1.el7.src.rpm",
457457
"comment": "The SRPM for scl6 and cc7 are the same, and they only provide cc7",
458+
"originalRepo": "http://xrootd.web.cern.ch/xrootd/sw/releases",
458459
"name": "xrootd",
459460
"pkgList": [
460461
"xrootd",
@@ -472,7 +473,8 @@
472473
"name": "davix",
473474
"packages": [
474475
{
475-
"src": "https://diracos.web.cern.ch/diracos/SRPM/davix-0.7.2-2.el6.src.rpm",
476+
"src": "https://diracos.web.cern.ch/diracos/SRPM/davix-0.7.5-1.el6.src.rpm",
477+
"originalRepo": "https://dl.fedoraproject.org/pub/epel/6/SRPMS/Packages/",
476478
"name": "davix"
477479
}
478480
]
@@ -535,7 +537,8 @@
535537
"buildOnly": true
536538
},
537539
{
538-
"src": "https://diracos.web.cern.ch/diracos/SRPM/gfal2-2.16.1-1.el6.src.rpm",
540+
"src": "https://diracos.web.cern.ch/diracos/SRPM/gfal2-2.17.1-1.el6_10.src.rpm",
541+
"originalRepo": "https://dl.fedoraproject.org/pub/epel/6/SRPMS/Packages/",
539542
"excludePatterns": [
540543
".*-doc-.*",
541544
".*-debuginfo-.*",

docs/50_troubleshoot.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,20 @@ The packages that are in `manualDependencies` are added to the dependencies that
9696

9797
## LDD check failing
9898

99-
The `check_ldd` test looks at the dependencies of the binaries in DIRACOS. It finds those pointing outside of DIRACOS (can be due to rpath) and those not found. There is a list of known "broken" dependencies (`tests/integration/knownMissingDependencies.txt`). Ideally, this list should be empty, but it will never be the case. So if you cannot do differently, you can always add your libraries there.
99+
The `check_ldd` test looks at the dependencies of the binaries in DIRACOS. It finds those pointing outside of DIRACOS (can be due to rpath) and those not found. There is a list of known "broken" dependencies (`tests/integration/knownMissingDependencies.txt`). Ideally, this list should be empty, but it will never be the case. So if you cannot do differently, you can always add your libraries there.
100+
101+
## ldconfig_scriptlets
102+
103+
Some spec files use `ldconfig_scriptlets` to trigger `ldconfig`. This does not work with DIRACOS because it relies on some packages in EPEL that we exclude on purpose. You can simply replace
104+
105+
```
106+
%ldconfig_scriptlets <A PACKAGE>
107+
```
108+
109+
with
110+
111+
```
112+
%post <A PACKAGE> -p /sbin/ldconfig
113+
114+
%postun <A PACKAGE> -p /sbin/ldconfig
115+
```

patches/davix.patch

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
diff -u -r original/davix.spec modified/davix.spec
2-
--- original/davix.spec 2019-03-20 11:54:36.000000000 +0100
3-
+++ modified/davix.spec 2019-05-08 17:37:46.416589447 +0200
4-
@@ -25,10 +25,6 @@
1+
diff -r -u original/davix.spec modified/davix.spec
2+
--- original/davix.spec 2019-08-28 09:13:40.000000000 +0000
3+
+++ modified/davix.spec 2020-02-13 14:16:43.513053440 +0000
4+
@@ -22,10 +22,6 @@
55
# davix-copy dependencies
66
BuildRequires: gsoap-devel
77
BuildRequires: libuuid-devel
@@ -12,7 +12,7 @@ diff -u -r original/davix.spec modified/davix.spec
1212

1313
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
1414
Requires: libuuid
15-
@@ -86,18 +82,15 @@
15+
@@ -83,18 +79,14 @@
1616
make %{?_smp_mflags}
1717
make doc
1818

@@ -21,7 +21,7 @@ diff -u -r original/davix.spec modified/davix.spec
2121
-#make abi-check
2222
-%endif
2323
-ctest -V -T Test
24-
24+
-
2525

2626
%install
2727
rm -rf %{buildroot}

patches/gfal2.patch

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
diff -r -u original/gfal2.spec modified/gfal2.spec
2+
--- original/gfal2.spec 2019-12-13 11:06:42.000000000 +0000
3+
+++ modified/gfal2.spec 2020-02-13 15:12:26.529528637 +0000
4+
@@ -283,7 +283,9 @@
5+
make DESTDIR=%{buildroot} install
6+
7+
8+
-%ldconfig_scriptlets
9+
+%post -p /sbin/ldconfig
10+
+
11+
+%postun -p /sbin/ldconfig
12+
13+
%files
14+
%{_bindir}/gfal2_version

patches/xrootd.patch

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
diff -r -u original/xrootd.spec modified/xrootd.spec
2-
--- original/xrootd.spec 2019-07-15 09:31:42.000000000 +0000
3-
+++ modified/xrootd.spec 2019-09-26 11:25:07.119885691 +0000
2+
--- original/xrootd.spec 2020-02-03 09:55:51.000000000 +0000
3+
+++ modified/xrootd.spec 2020-02-13 12:30:05.051221133 +0000
44
@@ -77,11 +77,6 @@
55
BuildRequires: json-c-devel
6-
6+
77
BuildRequires: python2-devel
88
-%if %{?fedora}%{!?fedora:0} >= 13
99
-BuildRequires: python3-devel
1010
-%else
1111
-BuildRequires: python%{python3_pkgversion}-devel
1212
-%endif
13-
13+
1414
BuildRequires: openssl-devel
15-
15+
1616
@@ -300,21 +295,6 @@
1717
%description -n python2-xrootd
1818
Python 2 bindings for XRootD
19-
19+
2020
-%if %{?_with_python3:1}%{!?_with_python3:0}
2121
-#-------------------------------------------------------------------------------
2222
-# python3
@@ -32,44 +32,44 @@ diff -r -u original/xrootd.spec modified/xrootd.spec
3232
-%description -n python3-xrootd
3333
-Python 3 bindings for XRootD
3434
-%endif
35-
35+
3636
#-------------------------------------------------------------------------------
3737
# doc
3838
@@ -464,12 +444,6 @@
3939
popd
4040
%endif
41-
41+
4242
-%if %{?_with_python3:1}%{!?_with_python3:0}
4343
-# build python3 bindings
4444
-pushd build/bindings/python
4545
-%py3_build
4646
-popd
4747
-%endif
48-
48+
4949
#-------------------------------------------------------------------------------
5050
# Installation
5151
@@ -586,12 +560,6 @@
5252
install -m 644 -p packaging/common/xrootd.pp \
5353
%{buildroot}%{_datadir}/selinux/packages/%{name}/%{name}.pp
54-
54+
5555
-%if %{?_with_python3:1}%{!?_with_python3:0}
5656
-# install python3 bindings
5757
-pushd build/bindings/python
5858
-%py3_install
5959
-popd
6060
-%endif
61-
61+
6262
%clean
6363
rm -rf $RPM_BUILD_ROOT
64-
@@ -880,11 +848,6 @@
64+
@@ -883,11 +851,6 @@
6565
%files -n python2-%{name} -f xrootd/build/PYTHON_INSTALLED_FILES
6666
%defattr(-,root,root,-)
67-
67+
6868
-%if %{?_with_python3:1}%{!?_with_python3:0}
6969
-%files -n python3-%{name}
7070
-%defattr(-,root,root,-)
7171
-%{python3_sitearch}/*
7272
-%endif
73-
73+
7474
%files doc
75-
%defattr(-,root,root,-)
75+
%defattr(-,root,root,-)

tests/integration/knownMissingDependencies.txt

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
1-
libICE.so.6
2-
libSM.so.6
3-
libXdamage.so.1
4-
libXfixes.so.3
5-
libXft.so.2
6-
libXrender.so.1
7-
libXxf86vm.so.1
81
libacl.so.1
92
libasound.so.2
103
libaudit.so.1
11-
libc.so.6
124
libcap.so.2
135
libcrypt.so.1
6+
libc.so.6
147
libdbus-glib-1.so.2
158
libdl.so.2
169
libdrm.so.2
@@ -28,23 +21,25 @@ libgstinterfaces-0.10.so.0
2821
libgstreamer-0.10.so.0
2922
libgstvideo-0.10.so.0
3023
libhesiod.so.0
24+
libICE.so.6
3125
libidn.so.11
3226
libjpeg.so.62
3327
liblua-5.1.so
34-
libm.so.6
3528
libmagic.so.1
3629
libmng.so.1
30+
libm.so.6
3731
libnsl.so.1
3832
libpcreposix.so.0
3933
libpixman-1.so.0
4034
libpopt.so.0
4135
libpthread.so.0
4236
libreadline.so.5
4337
libresolv.so.2
44-
librpm.so.1
4538
librpmbuild.so.1
4639
librpmio.so.1
40+
librpm.so.1
4741
librt.so.1
42+
libSM.so.6
4843
libstdc++.so.6
4944
libthai.so.0
5045
libtiff.so.3
@@ -53,4 +48,10 @@ libutil.so.1
5348
libxcb-dri2.so.0
5449
libxcb-glx.so.0
5550
libxcb.so.1
51+
libXdamage.so.1
52+
libXfixes.so.3
53+
libXft.so.2
54+
libxml2.so.2
55+
libXrender.so.1
56+
libXxf86vm.so.1
5657
libz-a147dcb0.so.1.2.3

0 commit comments

Comments
 (0)