Adding Venom Modules on macOS 15

[michaelt47]

I've forked Cardinal and was able to modify a couple of things in some of the submodules to get Cardinal building on macOS 15.4.1, and now I'm trying to add the Venom modules to my fork. I've gone through the process outlined in this discussion: #28

I've fixed a few of the bugs I've run into so far after following the steps in that guide, such as some struct names conflicting with structs of the same name in other plugins, but now I am stuck with this error:

Undefined symbols for architecture arm64:
  "getDefaultTheme()", referenced from:
      AuxClone::AuxClone() in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::setVenomPanel(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      std::__1::__function::__func<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda2'(), std::__1::allocator<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda2'()>, unsigned long ()>::operator()() in plugins.a[1753](AuxClone.cpp.o)
      BayModule::BayModule() in plugins.a[1754](BayInput.cpp.o)
      BayInputWidget::BayInputLabelsWidget::draw(rack::widget::Widget::DrawArgs const&) in plugins.a[1754](BayInput.cpp.o)
      ...
  "setDefaultTheme(int)", referenced from:
      std::__1::__function::__func<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda0'(int), std::__1::allocator<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda0'(int)>, void (unsigned long)>::operator()(unsigned long&&) in plugins.a[1753](AuxClone.cpp.o)
  "getDefaultDarkTheme()", referenced from:
      AuxClone::AuxClone() in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::setVenomPanel(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      std::__1::__function::__func<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda3'(), std::__1::allocator<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda3'()>, unsigned long ()>::operator()() in plugins.a[1753](AuxClone.cpp.o)
      BayModule::BayModule() in plugins.a[1754](BayInput.cpp.o)
      ...
  "setDefaultDarkTheme(int)", referenced from:
      std::__1::__function::__func<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda1'(int), std::__1::allocator<VenomWidget::appendContextMenu(rack::ui::Menu*)::'lambda1'(int)>, void (unsigned long)>::operator()(unsigned long&&) in plugins.a[1753](AuxClone.cpp.o)
  "_glfwGetKey", referenced from:
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
      MousePadWidget::step() in plugins.a[1780](MousePad.cpp.o)
  "_pluginInstance_Venom", referenced from:
      VenomWidget::setVenomPanel(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>) in plugins.a[1753](AuxClone.cpp.o)
      VenomWidget::step() in plugins.a[1753](AuxClone.cpp.o)
      PolyPort::PolyPort() in plugins.a[1753](AuxClone.cpp.o)
      BenjolinGatesExpanderWidget::ModeSwitch::ModeSwitch() in plugins.a[1757](BenjolinGatesExpander.cpp.o)
      BenjolinGatesExpanderWidget::PolaritySwitch::PolaritySwitch() in plugins.a[1757](BenjolinGatesExpander.cpp.o)
      BenjolinOscWidget::OverSwitch::OverSwitch() in plugins.a[1758](BenjolinOsc.cpp.o)
      BenjolinVoltsExpanderWidget::BinarySwitch::BinarySwitch() in plugins.a[1759](BenjolinVoltsExpander.cpp.o)
      ...
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Here is a link to my fork: https://github.com/michaelt47/Cardinal.git

I'm really unsure what to try at this point and I'm wondering if anyone has run into anything similar.

Update:

I was able to get rid of the default theme errors by changing this line:
PLUGIN_FILES += $(filter-out Venom/src/plugin.cpp,$(wildcard Venom/src/*.cpp))

to this:
PLUGIN_FILES += $(wildcard Venom/src/*.cpp)

I also rebuilt from scratch after this, and that got rid of the _pluginInstance_Venom error.
However, I'm still stuck with the _glfwGetKey error.

[dromer]

Unrelated to the error, but I see you made changes to both Surge and MindMeldModular which should not be needed.

[michaelt47]

Both modules had problems building with macOS 15.

With Surge, there were two lines that I had to change:
p.template emplace_back(x, y0 + (-tb[s] + 1) * 0.5 * hw);
replaced: p.emplace_back(x, y0 + (-tb[s] + 1) * 0.5 * hw);

ribbon.template emplace_back(x, y0 + (-tb[s] + 1) * 0.5 * hw);
replaced:ribbon.emplace_back(x, y0 + (-tb[s] + 1) * 0.5 * hw);

With MindMeld, there seemed to be one function that macOS had an issue with:
globalSends = simd::pow<simd::float_4>(globalSends, GlobalConst::globalAuxSendScalingExponent);

And got this error:

Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__type_traits/promote.h:32:18: error: static assertion failed due to requirement 'is_arithmetic<rack::simd::Vector<float, 4>>::value'
   32 |   static_assert((is_arithmetic<_Args>::value && ...));
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/complex:1110:47: note: in instantiation of template class 'std::__promote<rack::simd::Vector<float, 4>, int>' requested here
 1110 | inline _LIBCPP_HIDE_FROM_ABI complex<typename __promote<_Tp, _Up>::type> pow(const complex<_Tp>& __x, const _Up& __y) {
      |                                               ^
MindMeldModular/src/MixMaster/AuxExpander.cpp:612:19: note: while substituting deduced template arguments into function template 'pow' [with _Tp = simd::float_4, _Up = int, $2 = (no value)]
  612 |                                 globalSends = simd::pow<simd::float_4>(globalSends, GlobalConst::globalAuxSendScalingExponent);

There are a few occurrences of this in the AuxExpander module that I had to change to this:
globalSends = rack::simd::pow(globalSends, static_cast<float>(GlobalConst::globalAuxSendScalingExponent));

Both changes to each plugin seemed to not change the functionality of any of the modules, which I tested after these changes and with these changes I was able to build Cardinal without any further issues.