1주차 과제 #3

Sangwook123 · 2023-10-10T19:12:01Z

📌𝘐𝘴𝘴𝘶𝘦𝘴

closed 1주차 과제 #1

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

4d67fb54-9a1f-4e14-99a0-5dbec100365c.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

로그아웃 이외에도 회원탈퇴기능도 추가적으로 넣어봤습니다.

추가로 MVVM, DI 등등 적용해봤슴니다

Marchbreeze

진짜 이남자... 탐난다

Marchbreeze · 2023-10-11T06:14:17Z

app/src/main/java/org/sopt/dosopttemplate/di/RepositoryModule.kt

+    abstract fun bindsSharedPrefRepository(
+        sharedPrefRepository: SharedPrefRepositoryImpl
+    ): SharedPrefRepository
+}


@provides 대신 @BINDS 를 활용하신 이유가 있나요?

viewmodel에서 domain 레이어의 repository를 data의 구현부와 연결하여 사용하기위해 @BINDS 어노테이션을 활용했습니다

Marchbreeze · 2023-10-11T06:18:51Z

app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginActivity.kt

+        viewModel.setAutoLogin(user)
+        intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_CLEAR_TASK
+        startActivity(intent)
+    }


intent에 .apply{} 로 한번에 연결된 코드를 만들면 더 깔끔한 코드가 될 것 같습니다 !

Suggested change

}

this.toast(getString(R.string.login_success_login))

viewModel.setAutoLogin(user)

Intent(this, MainActivity::class.java).apply{

putExtra(USER_KEY, user)

addFlags(FLAG_ACTIVITY_NEW_TASK or FLAG_ACTIVITY_CLEAR_TASK)

startActivity(this)

}

Marchbreeze · 2023-10-11T06:19:45Z

app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginViewModel.kt

+        when (if (user == null) isValidLogin() else isValidLogin(user)) {
+            true -> _loginState.value = UiState.Success(sharedPrefRepository.getUserInfo())
+            false -> _loginState.value = UiState.Failure(CODE_FAILURE)
+        }


오호 when 문이 신기하네요 이거

Marchbreeze · 2023-10-11T06:20:34Z

app/src/main/java/org/sopt/dosopttemplate/presentation/main/MainActivity.kt

+            } else {//미만일때
+                finish()
+            }
+        }


backPressedTime 처럼 1500도 따로 상수화해주시면 더 유지보수가 용이할 듯 합니다 ~~

Marchbreeze · 2023-10-11T06:22:12Z

app/src/main/java/org/sopt/dosopttemplate/presentation/signup/SignupViewModel.kt

+            _signupState.value = UiState.Failure(CODE_INVALID_NICKNAME)
+        } else {
+            _signupState.value = UiState.Failure(CODE_INVALID_HOBBY)
+        }


else if 말고 when 문으로 더 깔끔하게 case를 나눌 수 있을 것 같습니다 ~~

Marchbreeze · 2023-10-11T06:22:21Z

app/src/main/java/org/sopt/dosopttemplate/presentation/signup/SignupViewModel.kt

+        private const val MIN_ID_LENGTH = 6
+        private const val MAX_ID_LENGTH = 10
+        private const val MIN_PW_LENGTH = 8
+        private const val MAX_PW_LENGTH = 12


상수화 폼 미쳤다

kez-lab

심화 도전 폼 무쳤고 가보자잇 ⚽️

kez-lab · 2023-10-13T00:00:28Z

app/build.gradle

    implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
+    implementation 'com.google.code.gson:gson:2.10.1'
    testImplementation 'junit:junit:4.13.2'
    androidTestImplementation 'androidx.test.ext:junit:1.1.5'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
+    implementation "com.google.dagger:hilt-android:2.44"
+    kapt "com.google.dagger:hilt-compiler:2.44"
+    implementation 'androidx.activity:activity-ktx:1.2.2'
+    implementation 'androidx.fragment:fragment-ktx:1.3.3'
+}


Gson도 좋지만 Kotlin serialization 이라는 라이브러리도 있습니다!

관련 글은 인간 안드로이드님의 블로그를 가져와봤어요 참고해보시면 좋을 것 같습니다!

넵 반영해보겠습니다 ㅎㅎ

kez-lab · 2023-10-13T00:12:11Z

app/src/main/java/org/sopt/dosopttemplate/data/entity/User.kt

+@Parcelize
+data class User(
+    val id: String = "",
+    val pw: String = "",
+    val nickname: String = "",
+    val hobby: String = ""
+) : Parcelable


Parcelable은 Android 플랫폼에 특화된 기능입니다, 따라서 Data Layer가 Android 프레임워크에 의존된 형태로 보입니다!

하지만 Data Layer에서는 데이터 액세스와 관련된 로직을 처리하기 때문에 Android 특정 의존성과 결합된다면 테스트의 용이성 및 유지보수 차원에서 문제가 발생할 수 있습니다.

그렇기 때문에 Presentation Layer의 Model을 통해서 Parcelize를 구현하는 것을 통해 의존성을 분리하는 것을 추천드립니다!

kez-lab · 2023-10-13T00:14:19Z

app/src/main/java/org/sopt/dosopttemplate/domain/repository/SharedPrefRepository.kt

+package org.sopt.dosopttemplate.domain.repository
+
+import org.sopt.dosopttemplate.data.entity.User
+
+interface SharedPrefRepository {
+    fun saveUserInfo(user: User?)
+    fun getUserInfo(): User?
+    fun setAutoLogin()
+    fun isAutoLogin(): Boolean
+    fun clearAutoLogin()
+    fun clearSharedPref()
+}


domain layer이기 때문에 domain 의존성만을 갖고있어야 할 것 같습니다! domain 패키지의 User Model 을 생성 후 Data Layer 의 User를 mapping하는 것을 추천드립니다!

kez-lab · 2023-10-13T00:16:14Z

app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginViewModel.kt

+    init {
+        autoLogin()
+    }


init Block 활용 너무 좋아욥~!!

amourxyoung

진짜 손폼미쳤네요... 너무너무 좋은 코드들이 많아서 많이 배워갑니당

amourxyoung · 2023-10-16T08:34:23Z

app/src/main/java/org/sopt/dosopttemplate/data/model/UserDto.kt

+    val nickname: String? = "",
+    val hobby: String? = ""
+) {
+    fun toUser(): User? {


엔티티화까지,,, 저두 이런식으로 리팩토링해야겠네요

amourxyoung · 2023-10-16T08:35:59Z

app/src/main/java/org/sopt/dosopttemplate/domain/repository/SharedPrefRepository.kt

+
+import org.sopt.dosopttemplate.domain.entity.User
+
+interface SharedPrefRepository {


진짜 mvvm 적용 폼 미쳤네,,,

amourxyoung · 2023-10-16T08:40:11Z

app/src/main/java/org/sopt/dosopttemplate/presentation/main/MainActivity.kt

+    private fun initLogoutStateObserver() {
+        viewModel.logoutState.observe(this) { state ->
+            when (state) {
+                is UiState.Success -> {


UiState 활용 굿이네용 👍

amourxyoung · 2023-10-16T08:41:31Z

app/src/main/java/org/sopt/dosopttemplate/util/intent/intentExt.kt

+import android.os.Build.VERSION_CODES.TIRAMISU
+import android.os.Parcelable
+
+fun <T : Parcelable> Intent.getParcelable(key: String, c: Class<T>): T? = when {


이거 쇽샥해가겠습니다

amourxyoung · 2023-10-16T11:46:00Z

app/src/main/java/org/sopt/dosopttemplate/presentation/model/UserModel.kt

@@ -0,0 +1,21 @@
+package org.sopt.dosopttemplate.presentation.model


이건 presentation에서 데이터 클래스 생성해주신 이유가 따로 있으실까요?

클린 아키텍처를 적용하고자 했습니다 ! parcelable data class가 data layer에서 정의 내려진다면 의진님 말씀처럼 data layer가 안드로이드 프레임워크에 의존성을 갖게된다 생각했고 domain layer는 어느곳에도 의존성을 갖지 않도록 순수 코틀린 코드로만 작성하고자 했습니다. 그래서 presentation의 model에서 구현해 주었습니다.

Sangwook123 added 17 commits October 11, 2023 02:49

[add] 그래들 종속성 추가

2ed7755

[add] DI 앱진입점

678ccbb

[feat] SharedPref 모듈

2a6afb9

[feat] sharedpref 인터페이스

2228e67

[feat] sharedpref 구현부

f154dd9

[feat] 리포지토리 모듈

eed5c4e

[add] hidekeyboard 확장함수

3ff2daf

[add] uistate sealed interface

2e16d3b

[add] string 리소스 추가

7425030

[refactor] viewmodel, databinding

97ab0e7

[feat] viewmodel, databinding, hilt, 자동로그인 구현

68ee441

[feat] main viewmodel, databinding, hilt, 로그아웃 및 회원탈퇴 구현

192bc21

[mod] 함수화

6681825

[mod] main 액티비티 intent flag, 함수화

d3f60e3

[feat] login 액티비티 intent flag

ebb9f2b

[chore] 주석

4950087

[chore] 자동로그인 로직 수정

be1b533

Sangwook123 added 심화 2️⃣ 심화 과제 도전 3️⃣ 도전 과제 labels Oct 10, 2023

Sangwook123 requested review from amourxyoung, Eonji-sw, lsakee, Marchbreeze, haeti-dev and CHANGEL1004 October 10, 2023 19:12

Sangwook123 self-assigned this Oct 10, 2023

[chore] 코드정렬

5c2515a

Marchbreeze reviewed Oct 11, 2023

View reviewed changes

[mod] 코드수정

00037f5

kez-lab reviewed Oct 13, 2023

View reviewed changes

Sangwook123 added 7 commits October 13, 2023 19:26

[add] kotlin serialization

7ecebe3

[mod] UserModel

e854340

[feat] DataSource

f5bde1a

[refactor] repository

4cb3607

[add] UserDto, User Data class

1cd9faf

[refactor] code

bfc61b5

[chore] package

2e48b6f

Sangwook123 requested a review from leeeha October 13, 2023 10:58

amourxyoung approved these changes Oct 16, 2023

View reviewed changes

amourxyoung reviewed Oct 16, 2023

View reviewed changes

Merge branch 'develop' into feature/seminar1-advanced-challenge

d6b1089

Sangwook123 merged commit 77acd66 into develop Oct 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1주차 과제 #3

1주차 과제 #3

Sangwook123 commented Oct 10, 2023 •

edited

Loading

Marchbreeze left a comment

Marchbreeze Oct 11, 2023

Sangwook123 Oct 12, 2023

Marchbreeze Oct 11, 2023

Marchbreeze Oct 11, 2023

Marchbreeze Oct 11, 2023

Marchbreeze Oct 11, 2023

Marchbreeze Oct 11, 2023

kez-lab left a comment

kez-lab Oct 13, 2023

Sangwook123 Oct 13, 2023

kez-lab Oct 13, 2023

kez-lab Oct 13, 2023

kez-lab Oct 13, 2023

amourxyoung left a comment

amourxyoung Oct 16, 2023

amourxyoung Oct 16, 2023

amourxyoung Oct 16, 2023

amourxyoung Oct 16, 2023

amourxyoung Oct 16, 2023

Sangwook123 Oct 16, 2023

-    }
+this.toast(getString(R.string.login_success_login))
+viewModel.setAutoLogin(user)
+Intent(this, MainActivity::class.java).apply{
+        putExtra(USER_KEY, user)
+        addFlags(FLAG_ACTIVITY_NEW_TASK or FLAG_ACTIVITY_CLEAR_TASK)
+        startActivity(this)
+}


		import org.sopt.dosopttemplate.domain.entity.User

		interface SharedPrefRepository {

		@@ -0,0 +1,21 @@
		package org.sopt.dosopttemplate.presentation.model

1주차 과제 #3

1주차 과제 #3

Conversation

Sangwook123 commented Oct 10, 2023 • edited Loading

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Marchbreeze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kez-lab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amourxyoung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sangwook123 commented Oct 10, 2023 •

edited

Loading