refactor: drop useless extra variables far callbacks

Author: Dabolus

src/pages/about.c

@@ -40,18 +40,10 @@ void about_loop(uint8_t *current_loop_count, uint8_t keys) {
   }
 
   // Allow scrolling by one row by pressing up or down
-  void (*about_me_scroll_row_up_handler)(void);
-  about_me_scroll_row_up_handler = &handle_about_me_scroll_row_up;
-  throttlekey(keys, J_UP, about_me_scroll_row_up_handler);
-
-  void (*about_me_scroll_row_down_handler)(void);
-  about_me_scroll_row_down_handler = &handle_about_me_scroll_row_down;
-  throttlekey(keys, J_DOWN, about_me_scroll_row_down_handler);
-
+  throttlekey(keys, J_UP, &handle_about_me_scroll_row_up);
+  throttlekey(keys, J_DOWN, &handle_about_me_scroll_row_down);
   // Allow scrolling by one page by pressing A
-  void (*about_me_scroll_page_down_handler)(void);
-  about_me_scroll_page_down_handler = &handle_about_me_scroll_page_down;
-  throttlekey(keys, J_A, about_me_scroll_page_down_handler);
+  throttlekey(keys, J_A, &handle_about_me_scroll_page_down);
 }
 
 #endif

src/pages/home_menu.c

@@ -160,21 +160,10 @@ void home_menu_loop(uint8_t *current_loop_count, uint8_t keys) {
     set_page(current_menu_option + 2);
   }
 
-  void (*menu_navigation_up_handler)(void);
-  menu_navigation_up_handler = &handle_menu_navigation_up;
-  throttlekey(keys, J_UP, menu_navigation_up_handler);
-
-  void (*menu_navigation_right_handler)(void);
-  menu_navigation_right_handler = &handle_menu_navigation_right;
-  throttlekey(keys, J_RIGHT, menu_navigation_right_handler);
-
-  void (*menu_navigation_down_handler)(void);
-  menu_navigation_down_handler = &handle_menu_navigation_down;
-  throttlekey(keys, J_DOWN, menu_navigation_down_handler);
-
-  void (*menu_navigation_left_handler)(void);
-  menu_navigation_left_handler = &handle_menu_navigation_left;
-  throttlekey(keys, J_LEFT, menu_navigation_left_handler);
+  throttlekey(keys, J_UP, &handle_menu_navigation_up);
+  throttlekey(keys, J_RIGHT, &handle_menu_navigation_right);
+  throttlekey(keys, J_DOWN, &handle_menu_navigation_down);
+  throttlekey(keys, J_LEFT, &handle_menu_navigation_left);
 }
 
 #endif

src/pages/projects.c

@@ -51,16 +51,10 @@ void projects_loop(uint8_t *current_loop_count, uint8_t keys) {
     set_page(HOME_MENU);
   }
 
-  void (*projects_navigation_prev_handler)(void);
-  projects_navigation_prev_handler = &handle_projects_navigation_prev;
-
-  void (*projects_navigation_next_handler)(void);
-  projects_navigation_next_handler = &handle_projects_navigation_next;
-
-  throttlekey(keys, J_UP, projects_navigation_prev_handler);
-  throttlekey(keys, J_RIGHT, projects_navigation_next_handler);
-  throttlekey(keys, J_DOWN, projects_navigation_next_handler);
-  throttlekey(keys, J_LEFT, projects_navigation_prev_handler);
+  throttlekey(keys, J_UP, &handle_projects_navigation_prev);
+  throttlekey(keys, J_RIGHT, &handle_projects_navigation_next);
+  throttlekey(keys, J_DOWN, &handle_projects_navigation_next);
+  throttlekey(keys, J_LEFT, &handle_projects_navigation_prev);
 }
 
 #endif

src/pages/skills.c

@@ -42,18 +42,10 @@ void skills_loop(uint8_t *current_loop_count, uint8_t keys) {
   }
 
   // Allow scrolling by one row by pressing up or down
-  void (*skills_scroll_row_up_handler)(void);
-  skills_scroll_row_up_handler = &handle_skills_scroll_row_up;
-  throttlekey(keys, J_UP, skills_scroll_row_up_handler);
-
-  void (*skills_scroll_row_down_handler)(void);
-  skills_scroll_row_down_handler = &handle_skills_scroll_row_down;
-  throttlekey(keys, J_DOWN, skills_scroll_row_down_handler);
-
+  throttlekey(keys, J_UP, &handle_skills_scroll_row_up);
+  throttlekey(keys, J_DOWN, &handle_skills_scroll_row_down);
   // Allow scrolling by one page by pressing A
-  void (*skills_scroll_page_down_handler)(void);
-  skills_scroll_page_down_handler = &handle_skills_scroll_page_down;
-  throttlekey(keys, J_A, skills_scroll_page_down_handler);
+  throttlekey(keys, J_A, &handle_skills_scroll_page_down);
 }
 
 #endif

src/portfolio.c

@@ -28,9 +28,7 @@ void main() {
     uint8_t keys = joypad();
 
     // Allow switching theme by pressing Select
-    void (*theme_change_handler)(void);
-    theme_change_handler = &handle_theme_change;
-    throttlekey(keys, J_SELECT, theme_change_handler);
+    throttlekey(keys, J_SELECT, &handle_theme_change);
 
     // Allow going back to the home header from any page
     // by pressing Start